Skip to content

fix(llm): bound model-info discovery with a timeout to prevent deadlocks - #3912

Open
bconsolvo wants to merge 10 commits into
OpenHands:mainfrom
bconsolvo:fix/model-info-discovery-deadlock
Open

bconsolvo wants to merge 10 commits into
OpenHands:mainfrom
bconsolvo:fix/model-info-discovery-deadlock

Conversation

@bconsolvo

@bconsolvo bconsolvo commented Jun 29, 2026 •

Copy link
Copy Markdown

HUMAN:

This all started because when filling out the LLM profile, I put a couple of backslashes in the URL field by accident. From then on, the UI would crash and deadlock, and I couldn't do anything.

image

AGENT:

Why

Model-info discovery for self-hosted / OpenAI-compatible providers (e.g.
lemonade, ollama, vllm) is resolved by a synchronous HTTP request with no
timeout
inside LiteLLM. LLM construction triggers this probe eagerly in
_post_init (_init_model_info_and_caps → get_litellm_model_info). If the
model endpoint is unreachable — or, in a topology where a reverse proxy forwards
the provider's default port back to the server itself, loops back to the
caller — the request hangs forever.

Because the agent-server constructs LLMs on its asyncio event loop (e.g.
GET /profiles/{name} → store.load()), one hung probe freezes the entire
server
: every subsequent request (server_info, settings, delete, …) times out.

Captured hang (py-spy) of the agent-server's main thread:

read (httpcore/_backends/sync.py:128)          # blocked, no timeout
...
get_model_info (litellm/.../lemonade/chat/transformation.py:182)
get_litellm_model_info (openhands/sdk/llm/utils/model_info.py:93)
_init_model_info_and_caps (openhands/sdk/llm/llm.py:2091)
_post_init → load (llm_profile_store.py:206) → get_profile (profiles_router.py:168)

Summary

  • openhands-sdk/.../llm/utils/model_info.py: bound every model-info network
    probe with a deadline (MODEL_INFO_DISCOVERY_TIMEOUT, default 10s). On
    timeout, discovery returns None — a state callers already handle, since
    model info is an optional enhancement. Also pass an explicit timeout to the
    litellm-proxy httpx.get.
  • The agent-server side (keeping store.load() off the event loop) is now
    covered by main: refactor(agent-server): reach stores through run_store and enable ruff ASYNC #6781 made get_profile, activate_profile and
    PATCH /api/settings sync endpoints that FastAPI runs in its threadpool, so
    this PR no longer touches profiles_router.py. The deadline here still
    matters: without it a hung probe pins a threadpool worker indefinitely.

Issue Number

Related to #4263 (model-info probe makes an unvalidated, un-timed httpx.get
at LLM init). This PR bounds that probe with a deadline so it can no longer
hang LLM construction or the agent-server event loop.

How to Test

uv run pytest tests/sdk/llm/test_model_info_discovery_timeout.py \
              tests/sdk/llm/test_model_info_proxy_lookup.py \
              tests/sdk/llm/test_llm.py

New test test_model_info_discovery_timeout.py simulates a hanging probe
(including the litellm-proxy underlying-model probe) and asserts discovery
returns within the deadline instead of blocking.

Manual repro (agent-server): create a self-hosted profile whose model-info
endpoint is unreachable (or loops back through the ingress). Before: the first
GET /api/profiles/{name} hangs and every later request times out. After: it
returns promptly and the server stays responsive.

Video/Screenshots

py-spy stack above is the captured deadlock. Local run on the latest head
(merged with current main): discovery-timeout, proxy-lookup, test_llm.py,
test_profiles_router.py and test_settings_router.py -> 402 passed;
ruff check, ruff format --check and pyright clean on changed files.

Type

  • Bug fix
  • Feature
  • Refactor
  • Breaking change
  • Docs / chore

Notes

model_info == None is already handled throughout the codebase; this change
only makes that fallback reachable on a hang rather than blocking forever. The
deadline runs each probe on its own daemon thread; a timed-out probe is
abandoned (uncancellable) but never blocks the caller or interpreter shutdown.

Jev-Fast-Audit

⚡ Jev fast audit · estimates · 0.34s · commit 98db909
Strongest signal: No primary concern selected.
Evidence: No primary concern to locate.
Coverage: complete supplied coverage; 12/12 hunks, 4/4 files.

All estimates and evidence
Estimate Likelihood / value Direct evidence
SQL injection 3.0% No direct hunk selected
Command injection 3.0% No direct hunk selected
Weakened authentication 4.0% No direct hunk selected
Weakened authorization 6.0% No direct hunk selected
Contract regression 13.0% No direct hunk selected
Data loss 3.0% No direct hunk selected
Sensitive data disclosure 4.0% No direct hunk selected
Unexpected data transfer 4.0% No direct hunk selected
Credential misuse 8.0% No direct hunk selected
Untrusted instruction authority 2.0% No direct hunk selected
Package source redirection 4.0% No direct hunk selected
Unverified remote execution 2.0% No direct hunk selected
Privileged environment access 3.0% No direct hunk selected
Security assessment bypass 4.0% No direct hunk selected
Prohibited workload 2.0% No direct hunk selected
Primary concern None selected; confidence 88.0% No primary concern to locate

Model-info discovery for self-hosted / OpenAI-compatible providers (lemonade, ollama, vllm) issues a synchronous HTTP request with no timeout. When the endpoint is unreachable -- or loops back to the caller via a reverse proxy -- the call hangs forever. Because LLM construction runs this probe in _post_init, the hang freezes any caller, including the agent-server event loop (every request times out).

Bound every probe with a deadline (returns None on timeout; callers already treat model_info=None as valid) and run the blocking profile load off the event loop in the agent-server profile endpoints.

Co-authored-by: Cursor <cursoragent@cursor.com>
@all-hands-bot

Copy link
Copy Markdown
Collaborator

[Automatic Post]: It has been a while since there was any activity on this PR. @bconsolvo, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

This comment was posted by an AI agent (OpenHands) on behalf of the user.

@all-hands-bot

Copy link
Copy Markdown
Collaborator

[Automatic Post]: It has been a while since there was any activity on this PR. @bconsolvo, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

This comment was created by an AI agent (OpenHands) on behalf of the user.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 40 days with no activity. Remove the stale label or leave a comment, otherwise it will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Sep 8, 2026
…ery-deadlock

# Conflicts:
#	openhands-agent-server/openhands/agent_server/profiles_router.py
#	openhands-sdk/openhands/sdk/llm/utils/model_info.py
@bconsolvo
bconsolvo marked this pull request as ready for review September 17, 2026 12:36
@bconsolvo

Copy link
Copy Markdown
Author

Merged latest main and resolved the two conflicts, then marked this ready for review.

Conflict resolution

  • openhands-sdk/.../llm/utils/model_info.py — import-only conflict. main added from collections.abc import Mapping (for the new proxy-alias pricing helpers, [Bug]: Native LLM spans record gen_ai.usage.cost = 0.0 for custom litellm_proxy/* model names #4816) while this branch added the Callable / ThreadPoolExecutor imports for the discovery deadline. Combined both: from collections.abc import Callable, Mapping plus the concurrent.futures import. Both features now coexist — the deadline wrapper (_run_with_deadline) and main's _register_proxy_alias_pricing.

  • openhands-agent-server/.../profiles_router.py — two conflicts, both from main renaming _store_errors → store_errors and changing the store.load() call sites:

    • get_profile: kept main's resolve_provider=False (display-as-stored, no dangling-reference failure) and this branch's run_in_threadpool off-loop wrapping → await run_in_threadpool(store.load, name, cipher=cipher, resolve_provider=False).
    • activate_profile: activation intentionally resolves the provider (default resolve_provider=True), so kept main's call form and wrapped it in run_in_threadpool.

Verification

  • uv run pytest tests/sdk/llm/test_model_info_discovery_timeout.py tests/agent_server/test_profiles_router.py → 106 passed.
  • ruff check on both resolved files → clean.

@all-hands-bot

Copy link
Copy Markdown
Collaborator

🚦 CI is currently failing on this PR's latest commit.

Please fix the failing checks before OpenHands reviews it - this is re-checked automatically once you push a new commit. (A maintainer can also request @all-hands-bot as a reviewer to have it reviewed regardless of CI status.)

This is an automated check - no AI was used to generate this comment.

@bconsolvo

Copy link
Copy Markdown
Author

Addressed the failing CI check.

Failure: The only failing check was Validate PR description — a policy gate (.github/scripts/check_pr_description.py), not a code/test failure. It requires a real issue linked in the ## Issue Number section, and the body still said N/A:

Link an issue in the ## Issue Number section (e.g. Fixes #123). Newly opened issues must carry the ready-for-dev label.

Fix: Linked #4263 in the ## Issue Number section. That issue flags the same call site — get_litellm_model_info making an unvalidated, un-timed httpx.get at LLM init — which this PR bounds with a deadline. (#4263 predates the ready-for-dev rollout of 2026-08-13, so it satisfies the check without a label change.)

Verified locally with python .github/scripts/check_pr_description.py --body-file … → PR description validation passed, and the Validate PR description check is now green on the PR. No code changes were needed — the merge-conflict resolution from the prior push is unaffected.

@github-actions github-actions Bot removed the Stale label Sep 18, 2026

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was posted by an AI agent (OpenHands).

Reviewed head dd2dde97fd093429ec3d38b4362953560ae60f4e against main, with repo guidance (AGENTS.md, openhands-sdk/openhands/sdk/AGENTS.md, .agents/skills/custom-codereview-guide.md).

The direction is right: bounding the synchronous model-info probe and moving the blocking store.load() off the event loop both address a real hang, and model_info is None is already handled downstream. But there is a concrete, reproduced CI-breaking regression, plus a shutdown-behavior concern in the new deadline helper.

1. Existing test breaks (blocking)

tests/sdk/llm/test_llm.py::test_base_url_for_openhands_provider (unchanged by this PR) asserts the exact httpx.get(...) signature, so the added timeout= kwarg fails it. Reproduced on this head: uv run pytest tests/sdk/llm/test_llm.py -q -> 1 failed, 90 passed. Run tests covers tests/sdk, so this will fail CI once the fork workflows are approved. See inline comment.

2. Abandoned probe threads block process exit (non-blocking, but worth deciding now)

ThreadPoolExecutor joins its workers at interpreter shutdown, and a probe that timed out cannot be cancelled, so the 10s deadline bounds the caller but not the process. This is visible in the PR's own test file: it reports 3 passed in 0.68s yet the process takes ~40s to exit. See inline comment.

Verification notes

  • Current head still matches dd2dde97fd093429ec3d38b4362953560ae60f4e; PR is open, mergeable_state blocked.
  • Checks for this head: only PR Description Check and PR Artifacts have completed successfully (later re-runs). Run tests, Pre-commit checks, REST API breakage checks, Persisted settings compatibility checks, TypeScript client CI, and the rest are action_required (fork workflows awaiting approval), so CI has not yet validated this head. The local reproduction above stands on its own.
  • tests/sdk/llm/test_model_info_discovery_timeout.py passes (3 passed), and tests/sdk/llm/test_model_info_proxy_lookup.py passes (12 passed).
  • Linked issue #4263 is still open with labels bug, needs-triage; its stated ask (validating the target before the probe) is not what this PR changes, but the timeout/off-box-egress angle is adjacent.

Eval / benchmark note

Per the repo review guide, changes that can affect agent behavior are not approved without eval evidence. This change can alter derived max_output_tokens/max_input_tokens when discovery times out, so a maintainer should confirm that is acceptable before merge.

Scope

In-repo and correctly owned by this repository (SDK + agent-server), so no cross-repo move is needed.

🔄 CHANGES REQUESTED

- tests/sdk/llm/test_llm.py: the model-info probe now passes an explicit
  timeout to httpx.get, so test_base_url_for_openhands_provider must expect
  timeout=MODEL_INFO_DISCOVERY_TIMEOUT in the asserted call signature.
- model_info.py: run the bounded probe on a dedicated daemon thread instead of
  a module-level ThreadPoolExecutor. The pool's atexit handler joined abandoned
  (uncancellable) workers, so a reachable-but-silent endpoint turned the
  request-path deadlock into a ~40s shutdown hang and 4 stuck probes could
  saturate the pool. A daemon thread is never joined at exit and each probe
  gets its own thread.

Co-Authored-By: Claude <noreply@anthropic.com>
@bconsolvo

Copy link
Copy Markdown
Author

Thanks for the review — both findings addressed in 5173128.

1. Broken test assertion (blocking) — fixed

test_base_url_for_openhands_provider asserted the exact httpx.get(...) signature, which no longer matches now that the proxy lookup passes an explicit timeout. Updated the assertion to expect timeout=MODEL_INFO_DISCOVERY_TIMEOUT (and imported the constant), rather than relaxing the check, so it still pins the full call.

uv run pytest tests/sdk/llm/test_llm.py -q   ->  79 passed

2. Abandoned probe threads block process exit — fixed

Replaced the module-level ThreadPoolExecutor with a per-probe daemon thread in _run_with_deadline. The pool's atexit handler joined every worker, so an uncancellable probe stuck on a reachable-but-silent endpoint (bounded only by litellm's ~600s/6000s socket timeout) turned the request-path deadlock into a shutdown hang — and 4 such probes could saturate the pool and starve later discovery. A daemon thread is never joined at interpreter shutdown, and a fresh thread per call removes the shared-pool bottleneck.

Verified the shutdown hang is gone — the PR's own discovery-timeout file (which abandons sleep(30) workers) now exits promptly:

uv run pytest tests/sdk/llm/test_model_info_discovery_timeout.py
-> 3 passed in 0.70s, process exits in ~0.8s (was ~40s)

Full local verification on this head:

  • tests/sdk/llm/test_llm.py -> 79 passed
  • tests/sdk/llm/test_model_info_discovery_timeout.py -> 3 passed
  • tests/sdk/llm/test_model_info_proxy_lookup.py -> 12 passed
  • ruff check on both changed files -> clean

On the eval / derived-token-limits note

Agreed this is a maintainer call. The behavior is unchanged from the PR's existing design: on a discovery timeout, model_info is None — exactly the state callers already handle — so derived max_input_tokens/max_output_tokens fall back to the same defaults used whenever discovery returns nothing today. This change only makes that fallback reachable on a hang instead of blocking; it doesn't alter the non-timeout path. Happy to gather eval evidence if you'd like before merge.

bconsolvo and others added 2 commits October 1, 2026 13:50
Match the daemon-thread idiom in utils/async_executor.py: Thread.start() can
raise RuntimeError when the interpreter is shutting down and will not start new
threads. Model info is optional, so return None in that case rather than
probing inline (which could re-introduce the hang the deadline bounds).

Co-Authored-By: Claude <noreply@anthropic.com>
@all-hands-bot

all-hands-bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

⏳ Review waiting on checks

The current head 98db909d8596 still has checks that have not finished, so no review conversation was started:

  • Agent Server
  • Check Docstrings
  • Deprecation deadlines
  • PR Artifacts
  • Persisted settings compatibility checks
  • Pre-commit checks
  • REST API breakage checks
  • Review Thread Gate
  • Run tests
  • TypeScript client CI
  • TypeScript client endpoint audit
  • TypeScript client integration tests
  • Version bump guard

No action is needed. The scheduled scan retries once every check on the head reports a conclusion.

This is an automated check - no AI was used to generate this comment.

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was posted by an AI agent (OpenHands).

Reviewed head 85ce41728137e5f1654f5646a06ee6d460012424 against main, applying the repo guidance (AGENTS.md, openhands-sdk/openhands/sdk/AGENTS.md, .agents/skills/custom-codereview-guide.md, .pre-commit-config.yaml).

Prior findings re-verified as fixed. Both earlier observations on dd2dde97 are resolved on this head:

  • tests/sdk/llm/test_llm.py::test_base_url_for_openhands_provider now expects timeout=MODEL_INFO_DISCOVERY_TIMEOUT; pytest tests/sdk/llm/test_llm.py tests/sdk/llm/test_model_info_discovery_timeout.py tests/sdk/llm/test_model_info_proxy_lookup.py -> 94 passed.
  • The module-level ThreadPoolExecutor is replaced with a per-call daemon threading.Thread, which is no longer joined at interpreter shutdown. I re-measured the previously-40s exit: each test process now exits in ~10s, and a bare openhands.sdk import in the same venv also takes ~11s, so that residual is environment/import startup, not the abandoned probe. pyright on the changed module is clean (0 errors).

The direction remains right and the new guard for threading.Thread start during interpreter shutdown is a nice touch.

1. ruff-format gate fails (blocking)

The new threading.Thread(...) call is split across three lines although the single-line form is only 87 chars (line-length = 88). uv run ruff format --check openhands-sdk/openhands/sdk/llm/utils/model_info.py -> Would reformat. The Pre-commit checks job runs the ruff-format hook (uv run ruff format), which rewrites the file and fails the hook, so this head cannot pass that required check as-is. One-line fix; see inline comment.

2. The proxy path still contains an unbounded probe (blocking for the stated goal)

The PR states it bounds every model-info network probe, but _get_model_info_from_litellm_proxy still calls get_model_info(underlying_model) unwrapped. That is a litellm network probe, and it is reached exactly on the litellm_proxy/ + base_url path, i.e. the OpenHands proxy route used for openhands/* models and any litellm_proxy/* model. Reproduced on this head (inline comment has the detail): with the proxy returning a litellm_params.model alias and get_model_info hanging, get_litellm_model_info(model="litellm_proxy/foo") returned after 60.0s - the MODEL_INFO_DISCOVERY_TIMEOUT deadline was not applied. Since this runs inside LLM._post_init, the deadlock the PR set out to remove can still occur through this path. Please wrap this call in _run_with_deadline as well.

Verification notes

  • Head confirmed unchanged at 85ce41728137e5f1654f5646a06ee6d460012424; PR open, mergeable=MERGEABLE, mergeStateStatus=BLOCKED, reviewDecision=REVIEW_REQUIRED.
  • Checks for this head: only Validate PR description and check-pr-artifacts have completed successfully; Run tests, Pre-commit checks, Agent Server, REST API breakage checks, Persisted settings compatibility checks, TypeScript client *, Check Docstrings, Version bump guard, Review Thread Gate, and the rest are action_required (fork workflows awaiting approval). CI has therefore not yet validated this head; the findings above were reproduced locally.
  • Linked issue #4263 is still open with labels bug, needs-triage.

Eval / benchmark note

Per the repo review guide, changes that can affect agent behavior need eval evidence before approval. Bounding discovery can change derived max_input_tokens/max_output_tokens when a probe times out, so a maintainer should confirm that trade-off is acceptable.

🔄 CHANGES REQUESTED

bconsolvo and others added 3 commits October 5, 2026 17:44
The precommit CI hook runs `ruff format`; the multi-line threading.Thread(...)
call fits on one 88-col line, so ruff collapses it. Pre-apply to keep the hook
green.

Co-Authored-By: Claude <noreply@anthropic.com>
_get_model_info_from_litellm_proxy resolves a proxy alias, then probes the
underlying model via get_model_info() to make the alias priceable (OpenHands#4816).
That nested call was still unbounded -- a synchronous, network-bound litellm
lookup with no timeout -- and it runs inside LLM._post_init, so an unreachable
underlying endpoint on the litellm_proxy/* route could still freeze LLM
construction and the agent-server event loop, the exact deadlock this PR
targets. Wrap it with _run_with_deadline like the other probes.

Adds a regression test that stubs the proxy to advertise a distinct underlying
alias and makes get_model_info hang: without the wrap the call blocks ~30s,
with it the alias model_info returns promptly and the underlying probe is
abandoned.

Co-Authored-By: Claude <noreply@anthropic.com>
@neubig
neubig requested review from all-hands-bot and removed request for all-hands-bot October 15, 2026 17:32

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was posted by an AI agent (OpenHands).

Reviewed head 98db909d85967ebe141906a8231915ec99046eb9 against main, applying the repo guidance (AGENTS.md, openhands-sdk/openhands/sdk/AGENTS.md, openhands-agent-server/AGENTS.md, .agents/skills/custom-codereview-guide.md).

Prior findings resolved. Both earlier observations are fixed on this head and I re-verified them:

  • tests/sdk/llm/test_llm.py::test_base_url_for_openhands_provider now expects timeout=MODEL_INFO_DISCOVERY_TIMEOUT; uv run pytest tests/sdk/llm/test_llm.py tests/sdk/llm/test_model_info_discovery_timeout.py tests/sdk/llm/test_model_info_proxy_lookup.py -> 95 passed.
  • The threading.Thread(...) call is now a single 87-char line; uv run ruff format --check and uv run ruff check both pass on the changed files, so the Pre-commit checks ruff-format gate is clear.
  • The previously-unbounded proxy probe is now wrapped (_run_with_deadline(get_model_info, underlying_model)), with a regression test that exercises it.

1. PR does not merge - conflict with main (blocking)

mergeable: false, mergeable_state: dirty. git merge-tree --write-tree HEAD origin/main reports a content conflict in openhands-agent-server/openhands/agent_server/profiles_router.py at the very store.load(...) call this PR edits: current main changed it to store.load(name, cipher=cipher, resolve_provider=expose_mode == "plaintext"), which collides with this branch's resolve_provider=False + run_in_threadpool wrap. Please rebase/merge main and re-resolve, keeping main's resolve_provider=expose_mode == "plaintext" semantics inside the off-loop run_in_threadpool(...) call. Until this is resolved the change cannot merge.

2. Same on-loop LLM construction remains in the settings route (non-blocking)

The PR moves profile store.load() (which constructs an LLM and runs the model-info probe) off the loop in get_profile and activate_profile, and documents that hazard at profiles_router.py:188-191. The identical operation still runs on the loop in settings_router.py: async PATCH /api/settings (update_settings, line 181) -> _apply_settings_update -> _load_active_profile_llm -> profile_store.load(profile_name, cipher=cipher) (line 259). After this PR the probe is bounded (~10s) rather than indefinite, so this is no longer a deadlock and it is not a regression - but it is inconsistent with the off-loop treatment introduced here, and it is the same "activate a profile" workflow the PR targets (update_settings docstring: "same as POST /api/profiles/{name}/activate"). Wrapping it in run_in_threadpool would make the fix consistent. Not blocking.

Verification notes

  • Head confirmed at 98db909d85967ebe141906a8231915ec99046eb9; PR open, mergeable=false, mergeable_state=dirty, labels [].
  • Checks for this head: only Validate PR description and check-pr-artifacts completed successfully; Run tests, Pre-commit checks, Agent Server, REST API breakage checks, Persisted settings compatibility checks, TypeScript client *, Check Docstrings, Version bump guard, Review Thread Gate are all action_required (fork workflows awaiting approval), so CI has not validated this head. The findings above were reproduced locally.
  • Focused local runs on this head: tests/sdk/llm/test_model_info_discovery_timeout.py + test_model_info_proxy_lookup.py + test_llm.py -> 95 passed; tests/agent_server/test_profiles_router.py -> 106 passed. Pre-existing failures that also fail on main (tests/sdk/llm/auth/test_credentials.py, test_model_list.py::test_openrouter_entries_are_real_catalog_ids, three test_model_features.py::test_reasoning_effort_support cases) are environmental and not caused by this PR.
  • Linked issue #4263 is now closed (labels bug, needs-triage); the PR still references it.

Eval / benchmark note

Per the repo review guide, changes that can alter derived max_input_tokens/max_output_tokens on a discovery timeout should have a maintainer confirm the trade-off. The change only makes the existing model_info is None fallback reachable on a hang, so the risk is low, but a maintainer should sign off.

🔄 CHANGES REQUESTED

bconsolvo and others added 2 commits November 18, 2026 09:52
…overy-deadlock

# Conflicts:
#	openhands-agent-server/openhands/agent_server/profiles_router.py
… test

main now tags proxy-sourced model info with `_capability_source: "proxy"`,
so the exact-dict assertion in the underlying-probe regression test must
include it. The deadline behavior under test is unchanged.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants