refactor(previews): implement preview key and i18n name#446
Merged
xrgzs merged 5 commits intoOpenListTeam:mainfrom Apr 3, 2026
Merged
refactor(previews): implement preview key and i18n name#446xrgzs merged 5 commits intoOpenListTeam:mainfrom
xrgzs merged 5 commits intoOpenListTeam:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds i18n-backed labels for the home “preview” dropdown so built-in preview options (including Download) can be localized via the existing translation system, addressing #442.
Changes:
- Replace hardcoded preview display names with i18n keys (
home.preview.names.*) in preview list generation. - Refactor preview definitions to use a stable
keyfor translation lookup. - Add English translations for built-in preview names under
home.preview.namesinsrc/lang/en/home.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pages/home/previews/index.ts | Switch preview option labels from hardcoded strings to useT() translations keyed by a new Preview.key. |
| src/lang/en/home.json | Add home.preview.names translation entries for built-in preview options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
7 tasks
xrgzs
changed the title
ILoveScratch2
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
preview查询参数，支持传入 Preview 组件的 key，方便直接打开对应的 PreviewMotivation and Context / 背景
Closes #442
How Has This Been Tested? / 测试
直接下载组件：
?preview=downloadChecklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。