Add point and wire output regressions for new output module#384
Open
lmdiazangulo wants to merge 2 commits into
Open
Add point and wire output regressions for new output module#384lmdiazangulo wants to merge 2 commits into
lmdiazangulo wants to merge 2 commits into
Conversation
lmdiazangulo
added
Observation
AI assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused end-to-end regression tests for issue #361 on top of the #376 output-module refactor branch.
Changes
test/pyWrapper/test_output_module_regression.pywith:planewave/pw-in-box) validating field/incident behavior and shielding before/after region.towelHanger) validating waveform correlation against known reference outputs..github/workflows/ubuntu.yml:new-output-module=OFF.new-output-module=ON(MPI OFF only) to validate point/wire outputs in CI.Validation
python3 -m pytest test/pyWrapper/test_output_module_regression.py -vvRefs #361