Skip to content

fix(express): connect to http and localhost wikis - #234

Merged
LukasGold merged 1 commit into
stagefrom
fix/express-http-scheme
Nov 18, 2026
Merged

LukasGold merged 1 commit into
stagefrom
fix/express-http-scheme

Conversation

@LukasGold

Copy link
Copy Markdown
Contributor

Problem

OswExpress could not connect to a wiki that serves only http, or to a local host such as localhost:8081 (for example a local OpenSemanticLab wiki in Docker):

  • The reachability check in OswExpress.__init__ always used https://{domain}/wiki/Main_Page. A domain given as http://localhost:8081 became https://http://localhost:8081/....
  • OswExpress.validate_domain required a top-level domain and allowed no port, so it rejected localhost:8081.
  • The service layer (osw CLI and MCP server) passed the bare active domain to OswExpress, so an http:// instance iri lost its scheme before the connection.

Changes

  • src/osw/express.py
    • New field scheme ("https" by default, "http" allowed).
    • An http:// or https:// prefix of the domain selects the scheme. domain stays a bare host[:port], because other code builds URLs and IRIs from it.
    • The reachability check uses the scheme. WtSite receives the bare domain for https, as before, and http://<domain> for http.
    • The domain validator accepts dot-separated labels, including single-label hosts such as localhost or a Docker service name, IP addresses, and an optional port.
  • src/osw/service/config.py: new derive_connect_domain(iri), which keeps an http:// scheme of an instance iri. derive_domain stays unchanged.
  • src/osw/service/context.py and osw instances status (src/osw/cli/ops.py) connect with derive_connect_domain.

Usage

OSW_DOMAIN=http://localhost:8081 (or an http://... key in the credential file). Without a prefix, the scheme stays https, so existing setups behave as before.

Tests

  • New tests/test_express_domain.py: scheme prefix and local hosts with a faked network, domain and scheme validator cases.
  • New parametrized test in tests/test_service_context.py for the scheme passed to OswExpress.
  • make check and make test pass locally (1029 passed).
  • Manual check against a local OSL wiki in Docker on http://localhost:8081 (run by hand, output not attached): login, osw --json status reports connected: true, and an Action API query returns results.
  • Not tested against an http wiki: file upload, file download and page fetch.

- OswExpress takes an http:// or https:// prefix and keeps domain bare
- domain validator accepts single-label hosts and a port
- service context and instances status keep the http scheme
@github-actions

Copy link
Copy Markdown
Contributor

Release preview

Merging this PR would release v2.10.0 (current: v2.9.1).

Changelog preview (truncated)
## v2.10.0 (2026-11-18)

### Bug Fixes

- A wiki file finds its session without a URL
  ([`f3f1080`](https://github.com/OpenSemanticLab/osw-python/commit/f3f1080106c0c4f8c18386bceb9d9eafac098182))

- Botfilter for user sync
  ([`4d6f440`](https://github.com/OpenSemanticLab/osw-python/commit/4d6f4401c63a148c924bef89963b8f18bc8d4b0c))

- Follow properties and items when collecting category templates
  ([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
  [`55e500e`](https://github.com/OpenSemanticLab/osw-python/commit/55e500efb896f0a3d6bde98409b3a6f43a652bdc))

- Keep the stored jsonschema when store_entity regenerates it
  ([`9b76a8f`](https://github.com/OpenSemanticLab/osw-python/commit/9b76a8fbeb813b34c4881b54d329e9e837b08f95))

- One session per host and credential, named by host alone
  ([`f199283`](https://github.com/OpenSemanticLab/osw-python/commit/f1992832fa20969fc5a63d0a215ba59a9e796245))

- Path is a field again, in step with local_path
  ([`4ecbc7c`](https://github.com/OpenSemanticLab/osw-python/commit/4ecbc7caddb1558ac765ba38f654f37d55e1e58c))

- Select category templates from the schema allOf like the wiki
  ([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
  [`9f606f4`](https://github.com/OpenSemanticLab/osw-python/commit/9f606f48fefd640cca48e6718f1a92eca118da6b))

- **core**: Address follow-up issues in the overwrite policy
  ([`10808a0`](https://github.com/OpenSemanticLab/osw-python/commit/10808a05d1c27c5cf4053e79169d39ceeac16f99))

- **core**: Do not warn when a registered subclass was set aside
  ([`c116199`](https://github.com/OpenSemanticLab/osw-python/commit/c1161990e1ef6ebed6372c814ba2133c80258f5c))

- **core**: Drop skipped pages from StoreEntityPartialError.stored
  ([`cf78de9`](https://github.com/OpenSemanticLab/osw-python/commit/cf78de9f253700a92b8b44761dd4baa75050695e))

- **core**: Guard the registry conflict check against a non-class
  ([`0017ef0`](https://github.com/OpenSemanticLab/osw-python/commit/0017ef094e009dd3fe04096f11eea880bd2a4142))

- **core**: Ignore registered subclasses of the canonical model class
  ([`4ee1e09`](https://github.com/OpenSemanticLab/osw-python/commit/4ee1e09ee54f39258fb4f03d4b74f11de4a4c451))

- **core**: Prefer a registered class over a generated one
  ([`90fa310`](https://github.com/OpenSemanticLab/osw-python/commit/90fa310a8e8f71b8ce58d95c0a575e4e6607a1dd))

- **core**: Restore the page cache state once per fetch_schema call
  ([`f09dcf6`](https://github.com/OpenSemanticLab/osw-python/commit/f09dcf6b9d0e0bf3baf04107d9e1acf56e755c8d))

- **core**: Skip a page whose category has no usable schema
  ([`3c9278d`](https://github.com/OpenSemanticLab/osw-python/commit/3c9278d24baadce753f868ff39cbddccf9418494))

- **core**: Skip non-class attributes when choosing a category class
  ([`0ea247c`](https://github.com/OpenSemanticLab/osw-python/commit/0ea247c3452b207942fe08a23b596ec6e2d52f96))

- **core**: Use the current class after fetch_schema reloads the module
  ([`e39a857`](https://github.com/OpenSemanticLab/osw-python/commit/e39a857a20604718ee5dd7d1ed300b509baa7f8c))

- **express**: Connect to http and localhost wikis
  ([`99584f1`](https://github.com/OpenSemanticLab/osw-python/commit/99584f16d5720d83ba621a3ef4427a5b1f4744bd))

- **package**: Write packages.json pages in a deterministic order
  ([`467d11c`](https://github.com/OpenSemanticLab/osw-python/commit/467d11cc26a0a94f3a31936124740f33c31692c0))

- **user-sync**: Actually remove pruned fields via empty relations and remove_empty
  ([`87cf85b`](https://github.com/OpenSemanticLab/osw-python/commit/87cf85b31cbfec6b80e2e30b92852c359586133c))

- **user-sync**: Align with stage and the tools docs
  ([`bc6b0d6`](https://github.com/OpenSemanticLab/osw-python/commit/bc6b0d642f5697ca8048b4be05fd26c9ad2162f6))

- **user-sync**: Count and redirect only stored items
  ([#224](https://github.com/OpenSemanticLab/osw-python/pull/224),
  [`0b8dc97`](https://github.com/OpenSemanticLab/osw-python/commit/0b8dc974e972e8adaa7a2bb03bd3ae4396589f40))

- **user-sync**: Drop python-dotenv, use default accounts.pwd.yaml
  ([`02570c8`](https://github.com/OpenSemanticLab/osw-python/commit/02570c8f88d6d27c58e1e595bc8bb13e90354fd4))

- **user-sync**: Prune a single-valued key stored with an empty value
  ([`ebda514`](https://github.com/OpenSemanticLab/osw-python/commit/ebda514c731718ab20a084b93288491b3b944627))

- **user-sync**: Prune by field type and decide from stored jsondata

Preview via python-semantic-release and conventional commits.

@LukasGold
LukasGold merged commit 244dbcf into stage Nov 18, 2026
12 checks passed
@LukasGold
LukasGold deleted the fix/express-http-scheme branch November 18, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant