Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ testing =
setuptools
pytest
pytest-cov
opensemantic.core

[options.entry_points]
# Add here console scripts like:
Expand Down
4 changes: 4 additions & 0 deletions src/opensemantic/_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,10 @@ def get_title(entity: OswBaseModel) -> Union[str, NoneType]:
if entity.meta.wiki_page.title:
title = entity.meta.wiki_page.title

if title is None and custom_isinstance(entity, "Property"):
# Same rule as the wiki form editor: the name of a property is its title
title = getattr(entity, "name", None) or None

if title is None:
title = get_osw_id(entity)

Expand Down
4 changes: 4 additions & 0 deletions src/opensemantic/v1/_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@ def get_title(entity: OswBaseModel) -> Union[str, NoneType]:
if entity.meta.wiki_page.title:
title = entity.meta.wiki_page.title

if title is None and custom_isinstance(entity, "Property"):
# Same rule as the wiki form editor: the name of a property is its title
title = getattr(entity, "name", None) or None

if title is None:
title = get_osw_id(entity)

Expand Down
61 changes: 61 additions & 0 deletions tests/property_title_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
"""Tests for deriving the wiki page title of a Property from its name."""

import pytest


def _classes(version):
if version == "v2":
from opensemantic.core import AnnotationProperty, Item, QuantityProperty
else:
from opensemantic.core.v1 import AnnotationProperty, Item, QuantityProperty
return AnnotationProperty, QuantityProperty, Item


LABEL = [{"text": "label"}]


@pytest.mark.parametrize("version", ["v2", "v1"])
@pytest.mark.parametrize("cls_index", [0, 1])
def test_property_title_from_name(version, cls_index):
cls = _classes(version)[cls_index]
prop = cls(name="HasTestValue", label=LABEL)
assert prop.get_title() == "HasTestValue"
assert prop.get_iri() == "Property:HasTestValue"


@pytest.mark.parametrize("version", ["v2", "v1"])
def test_property_explicit_meta_title_wins(version):
prop_cls = _classes(version)[0]
prop = prop_cls(
name="HasTestValue",
label=LABEL,
meta={"wiki_page": {"title": "Custom"}},
)
assert prop.get_title() == "Custom"
assert prop.get_iri() == "Property:Custom"


@pytest.mark.parametrize("version", ["v2", "v1"])
def test_non_property_title_is_osw_id(version):
item_cls = _classes(version)[2]
item = item_cls(label=LABEL, name="SomeName")
assert item.get_title() == f"OSW{item.uuid.hex}"
assert item.get_iri() == f"Item:OSW{item.uuid.hex}"


@pytest.mark.parametrize("version", ["v2", "v1"])
def test_property_with_empty_name_falls_back_to_osw_id(version):
prop_cls = _classes(version)[0]
prop = prop_cls(name="HasTestValue", label=LABEL)
# the model rejects None as name, so an empty string is the only unset value
prop.name = ""
assert prop.get_title() == f"OSW{prop.uuid.hex}"
assert prop.get_iri() == f"Property:OSW{prop.uuid.hex}"


@pytest.mark.parametrize("version", ["v2", "v1"])
def test_property_name_derived_from_label_is_used_as_title(version):
prop_cls = _classes(version)[0]
prop = prop_cls(label=LABEL)
assert prop.name
assert prop.get_title() == prop.name
Loading