Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default TS reads
Rotors=<bool>andCustomRotor=<bool>. These keys had an effect in Red Alert, but TS does nothing with them. This pull request aims to change that.The
Draw_Rotors()function already existed in the OpenTS codebase, a duplicate of the same function in Red Alert. When called, it draws rotors.I haven't touched the absolute core of the behavior, which is to draw a SHP over an aircraft with
Rotors=yesset in its art entry, with different frames for when the unit is in flight versus when it is on the ground, and with translucency. I've also left Red Alert's default rotor loading behavior for when no rotor anim is explicitly specified, which looks forLROTORandRROTOR. Note however that these files do not exist in the vanilla TS version of Conquer.mix.I've added support for up to four rotors on an aircraft, controlled by
RotorCount=<int, 1-4>, and an FLH for each one. I've also added functionality to specify eight directional rotor anims for each rotor, for while the unit is in motion. This allows the shp to somewhat mimic the tilt of the voxel aircraft.For instance, here is what the Harpy's art.ini entry might look like:
Due to its irrelevance, I have removed the
CustomRotor=key. It didn't do anything before, and in this implementation customness of the rotors is controlled by specifyingRotor1Animanyway, so I don't feel this is a great loss.Attached is a zip file containing
LROTOR,RROTOR, and theAROTORfiles from the Harpy example, for convenience in testing.rotors.zip