Skip to content

fix:pipeline_config#264

Open
JarbasAl wants to merge 1 commit intodevfrom
fix/pipeline_config
Open

fix:pipeline_config#264
JarbasAl wants to merge 1 commit intodevfrom
fix/pipeline_config

Conversation

@JarbasAl
Copy link
Copy Markdown
Member

@JarbasAl JarbasAl commented Mar 3, 2026

since moving to pipeline plugins the plugin_id is expected as key

https://github.com/OpenVoiceOS/ovos-plugin-manager/blob/dev/ovos_plugin_manager/pipeline.py#L91

Summary by CodeRabbit

  • Configuration Updates
    • Intent pipeline configuration keys have been renamed to align with plugin naming conventions for improved clarity. Configuration values and functionality remain unchanged.

@github-actions github-actions Bot added the fix label Mar 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a259a3 and 68200d4.

📒 Files selected for processing (1)
  • ovos_config/mycroft.conf

📝 Walkthrough

Walkthrough

Configuration keys under the intents pipeline were renamed to reflect plugin-specific naming conventions. Four configuration keys—"adapt", "padatious", "common_query", and "OCP"—were updated to their plugin-specific equivalents while preserving all nested configuration values.

Changes

Cohort / File(s) Summary
Pipeline Configuration Keys Renamed
ovos_config/mycroft.conf
Intents pipeline configuration keys renamed: adaptovos-adapt-pipeline-plugin, padatiousovos-padatious-pipeline-plugin, common_queryovos-common-query-pipeline-plugin, OCPovos-ocp-pipeline-plugin. All nested configuration values and thresholds preserved under new keys.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 The config keys don a fresh new name,
Plugin-branded in the intents game,
Four simple swaps, values all the same,
A tidy refactor without a flame,
The pipeline now wears its colors bright!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix:pipeline_config' is vague and uses non-descriptive terminology that doesn't clearly convey the specific nature of the changes. Use a more descriptive title that specifies the actual change, such as 'Rename pipeline config keys to plugin-specific identifiers' or 'Update pipeline plugin configuration key names'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/pipeline_config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

JarbasAl added a commit to OpenVoiceOS/ovos-common-query-pipeline-plugin that referenced this pull request Mar 3, 2026
@github-actions github-actions Bot added fix and removed fix labels Mar 3, 2026
JarbasAl added a commit to OpenVoiceOS/ovos-common-query-pipeline-plugin that referenced this pull request Mar 3, 2026
* fix: mycroft.conf key

related PR OpenVoiceOS/ovos-config#264

* 📝 Add docstrings to `JarbasAl-patch-2`

Docstrings generation was requested by @JarbasAl.

The following files were modified:

* `ovos_commonqa/opm.py`

* Update opm.py

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
JarbasAl added a commit to OpenVoiceOS/ovos-adapt-pipeline-plugin that referenced this pull request Mar 3, 2026
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (5cae479) to head (68200d4).
⚠️ Report is 234 commits behind head on dev.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #264   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         10      10           
  Lines        837     857   +20     
=====================================
- Misses       837     857   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JarbasAl added a commit to OpenVoiceOS/ovos-padatious-pipeline-plugin that referenced this pull request Mar 3, 2026
JarbasAl added a commit to OpenVoiceOS/ovos-ocp-pipeline-plugin that referenced this pull request Mar 3, 2026
JarbasAl added a commit to OpenVoiceOS/ovos-padatious-pipeline-plugin that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants