add audio service ducking default config#82
add audio service ducking default config#82emphasize wants to merge 2 commits intoOpenVoiceOS:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #82 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 10
Lines ? 810
Branches ? 0
=====================================
Hits ? 0
Misses ? 810
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| // is playing | ||
| // NOTE: If the TTS config 'pulse_duck' is set to true, this setting will be ignored | ||
| // and pulse audio role ducking will be used instead. | ||
| "duck": true, |
There was a problem hiding this comment.
can we leave this as False by default for now? Kinda want the OCP sprint to be done before we change this, as i am introducing both "duck" and "cork" in there (volume change vs pause/unpause)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #82 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 10
Lines ? 810
Branches ? 0
=====================================
Hits ? 0
Misses ? 810
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lately, audio service ducking was introduced to OpenVoiceOS/ovos-audio@0a3b034
This makes the audio service ducking the default configuration
("Audio service ducking" will be invalidated if
"pulse_duck": trueis configured, ie. pulse is taking over to perform said task.)