Skip to content

add audio service ducking default config#82

Open
emphasize wants to merge 2 commits intoOpenVoiceOS:devfrom
emphasize:add/audio_service_ducking
Open

add audio service ducking default config#82
emphasize wants to merge 2 commits intoOpenVoiceOS:devfrom
emphasize:add/audio_service_ducking

Conversation

@emphasize
Copy link
Copy Markdown
Collaborator

Lately, audio service ducking was introduced to OpenVoiceOS/ovos-audio@0a3b034

This makes the audio service ducking the default configuration
("Audio service ducking" will be invalidated if "pulse_duck": true is configured, ie. pulse is taking over to perform said task.)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@5db2ab4). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #82   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      10           
  Lines          ?     810           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     810           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the documentation Improvements or additions to documentation label Dec 3, 2023
Comment thread ovos_config/mycroft.conf
// is playing
// NOTE: If the TTS config 'pulse_duck' is set to true, this setting will be ignored
// and pulse audio role ducking will be used instead.
"duck": true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we leave this as False by default for now? Kinda want the OCP sprint to be done before we change this, as i am introducing both "duck" and "cork" in there (volume change vs pause/unpause)

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev@5db2ab4). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #82   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      10           
  Lines          ?     810           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     810           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants