feat: drop _corrected suffix on merged CSV; mark raw histogram CSVs with _raw#45
Open
boringethan wants to merge 1 commit intonextfrom
Open
feat: drop _corrected suffix on merged CSV; mark raw histogram CSVs with _raw#45boringethan wants to merge 1 commit intonextfrom
boringethan wants to merge 1 commit intonextfrom
Conversation
…ith _raw Per OpenwaterHealth/openmotion-bloodflow-app#44, the SDK now writes the merged dark-baseline-corrected CSV as `<timestamp>_<subject>.csv` (was `<timestamp>_<subject>_corrected.csv`) and tags per-side raw histogram CSVs with a `_raw` suffix (`<timestamp>_<subject>_<side>_mask##_raw.csv`, was `<timestamp>_<subject>_<side>_mask##.csv`). Internal Python symbols (`corrected_path`, `corrected_columns`, `write_corrected_csv`, `ScanResult.corrected_path`) keep their names — only the on-disk filename changed; the file content is still dark-baseline-corrected. The bloodflow-app reader already tolerates both naming conventions (commit 44d08b2 on feature/44-output-file-naming). SDK-bundled consumers of SDK output (`scripts/view_corrected_scan.py`, `stream-db/importer.py`) gain the same back-compat tolerance so historical scan_data folders keep loading. `data-processing/{plot_corrected_scan,compare_pipelines}.py` accept user- supplied paths unchanged; only their docstrings and `--help` text were refreshed to describe the new convention while noting the legacy form is still accepted. Docs (`docs/PipelineComparison.md`, `docs/SciencePipeline.md`) updated to match. No test fixtures renamed — those are archived real captures whose filenames are part of the recorded artefact. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to OpenwaterHealth/openmotion-bloodflow-app#44.
Summary
omotion/ScanWorkflow.py:245— merged CSV no longer gets the_correctedsuffix ({ts}_{subject}_corrected.csv→{ts}_{subject}.csv).omotion/ScanWorkflow.py:703— per-side raw histogram CSVs (gated onrequest.write_raw_csv) now get a_rawsuffix.scripts/view_corrected_scan.py— globs both legacy*_corrected.csvand new layouts.stream-db/importer.py—FILENAME_REregex accepts an optional_rawafter the mask group.docs/PipelineComparison.md,docs/SciencePipeline.md,data-processing/plot_corrected_scan.py,data-processing/compare_pipelines.py).Internal Python symbols (
corrected_path,ScanResult.corrected_path,corrected_columns,write_corrected_csv, etc.) deliberately untouched — they describe content semantics, not the filename. Renaming would be a separate semver-affecting change.The bloodflow-app side already accepts both naming conventions on read (PR forthcoming on that repo against #44), so the two PRs can land independently.
Test plan
write_raw_csv=False— output CSV is named{ts}_{subject}.csv(no_corrected).write_raw_csv=True— per-side files named{ts}_{subject}_{side}_mask{mask:02X}_raw.csv.scripts/view_corrected_scan.pystill loads both legacy fixtures and new-style outputs.stream-db/importer.pyparses both old and new per-side filenames.🤖 Generated with Claude Code