Skip to content

Mo/rtd proxy safe merge #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplaroche merged 1 commit into from
May 21, 2026
Merged

Mo/rtd proxy safe merge #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/core/prebid/rtd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,12 @@ function merge(config: RTDConfig, targetORTB2: ORTB2, sourceORTB2: ORTB2): numbe
/* eslint-disable no-param-reassign */
targetORTB2.user = targetORTB2.user ?? {};
targetORTB2.user.ext = targetORTB2.user.ext ?? {};
targetORTB2.user.ext.eids = targetORTB2.user.ext.eids ?? [];
/* eslint-enable no-param-reassign */

// Use Object.getOwnPropertyDescriptor/defineProperty to bypass Prebid's ORTB2
// Proxy whose get trap blocks direct reads of `eids`.
const eidsDesc = Object.getOwnPropertyDescriptor(targetORTB2.user.ext, "eids");
let currentEids: EID[] = Array.isArray(eidsDesc?.value) ? eidsDesc.value : [];
let skipped = 0;

const eidsBySource =
Expand All @@ -267,8 +271,14 @@ function merge(config: RTDConfig, targetORTB2: ORTB2, sourceORTB2: ORTB2): numbe
}

const mergeFn = mergeStrategy(config, eidSource);
// eslint-disable-next-line no-param-reassign
targetORTB2.user!.ext!.eids = mergeFn(targetORTB2.user!.ext!.eids!, eids);
currentEids = mergeFn(currentEids, eids);
});

Object.defineProperty(targetORTB2.user!.ext!, "eids", {
value: currentEids,
writable: true,
enumerable: true,
configurable: true,
});
return skipped;
}
Expand Down
Loading