Skip to content

Remove 3rd native staking strategy from OETH Vault#2866

Merged
naddison36 merged 4 commits intomasterfrom
nicka/remove-3rd-staking-strat
Apr 6, 2026
Merged

Remove 3rd native staking strategy from OETH Vault#2866
naddison36 merged 4 commits intomasterfrom
nicka/remove-3rd-staking-strat

Conversation

@naddison36
Copy link
Copy Markdown
Collaborator

@naddison36 naddison36 commented Apr 2, 2026

Changes

  • Remove the 3rd Native Staking Strategy from the OETH Vault
  • The SSV in the 3rd SSV Cluster can no longer be removed using the old withdrawSSV function as it was expected the cluster would have been migrated to ETH Payments by now. migrateClusterToETH needs to be used instead to return the left over SSV in the cluster. But this can't be called until the SSV Network is upgrade. This has now been pushed back to mid April.
  • The 2nd Native Staking Strategy will remain until late May or early June when the validator consolidation has been completed. The strategy contract, unit tests, fork tests and hardhat tasks for all the Native Staking Strategies can be removed then.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.30%. Comparing base (6114b09) to head (5119ef7).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
- Coverage   55.26%   53.30%   -1.97%     
==========================================
  Files         112      112              
  Lines        4844     4844              
  Branches     1343     1343              
==========================================
- Hits         2677     2582      -95     
- Misses       2162     2257      +95     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for removing the obsolete defender action scripts
✅ the 3rd native staking strategy has only 10ˆ-8 ETH dust

@naddison36 naddison36 merged commit 5cb9b7a into master Apr 6, 2026
16 of 18 checks passed
@naddison36 naddison36 deleted the nicka/remove-3rd-staking-strat branch April 6, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants