Skip to content

Fix Slither CI#2870

Merged
sparrowDom merged 1 commit intomasterfrom
shah/slither-reentrancy-skip
Apr 2, 2026
Merged

Fix Slither CI#2870
sparrowDom merged 1 commit intomasterfrom
shah/slither-reentrancy-skip

Conversation

@shahthepro
Copy link
Copy Markdown
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.26%. Comparing base (1cdb84f) to head (e800775).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2870      +/-   ##
==========================================
+ Coverage   53.30%   55.26%   +1.96%     
==========================================
  Files         112      112              
  Lines        4844     4844              
  Branches     1343     1343              
==========================================
+ Hits         2582     2677      +95     
+ Misses       2257     2162      -95     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparrowDom sparrowDom merged commit 8770307 into master Apr 2, 2026
18 checks passed
@sparrowDom sparrowDom deleted the shah/slither-reentrancy-skip branch April 2, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants