Skip to content

Goodness of fit fix#473

Merged
plakrisenko merged 6 commits intomainfrom
goodness_of_fit_fix
Mar 18, 2026
Merged

Goodness of fit fix#473
plakrisenko merged 6 commits intomainfrom
goodness_of_fit_fix

Conversation

@plakrisenko
Copy link
Member

@plakrisenko plakrisenko commented Feb 4, 2026

What was displayed as Mean squared error, was't that.
Display Mean of squared normalized residuals instead

@plakrisenko plakrisenko requested a review from a team as a code owner February 4, 2026 20:26
@plakrisenko
Copy link
Member Author

Or better show MSE?

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.43%. Comparing base (7a60b2e) to head (c71f742).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
petab/v1/visualize/plot_residuals.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   75.46%   75.43%   -0.03%     
==========================================
  Files          62       62              
  Lines        6895     6899       +4     
  Branches     1227     1228       +1     
==========================================
+ Hits         5203     5204       +1     
- Misses       1221     1223       +2     
- Partials      471      472       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better show MSE?

It might be nice to have different options, but I'm not sure what should be the default.

@plakrisenko plakrisenko merged commit 076f9ef into main Mar 18, 2026
13 checks passed
@plakrisenko plakrisenko deleted the goodness_of_fit_fix branch March 18, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants