Cache _load_architecture by model_type#36
Merged
Conversation
Architecture yaml was reloaded once per scheduler iteration when running with --analytical-modeling. The non-analytical path goes through _load_perf_db which is cached, but the analytical branch in _build_trace_ctx calls _load_architecture directly with no cache. For a 33-iter baseline run on Llama-3.1-8B this accounted for ~12% of total wall-clock (~10ms per iter on yaml.safe_load).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture yaml was reloaded once per scheduler iteration when running with --analytical-modeling. The non-analytical path goes through _load_perf_db which is cached, but the analytical branch in _build_trace_ctx calls _load_architecture directly with no cache.
For a 33-iter baseline run on Llama-3.1-8B this accounted for ~12% of total wall-clock (~10ms per iter on yaml.safe_load).