Repository navigation
fix: improve card separation and overlay contrast - #128
Conversation
Keep book and shelf shadows visible in dark mode and preserve readable favorite and selection icons across cover colors and theme variants. Closes #127.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Issue and requirements
Closes #127. Covers the card-specific portions of NFR-5_1 (design system) and NFR-5_2 (accessibility).
Summary
Book and shelf cards blend into the page in dark mode, and favorite/selection icons lose contrast against their gray overlays in light mode. Use a subtle gray elevation shadow for dark book and shelf cards, plus pale theme colors for light-mode overlay icons.
Keep the same colored-icon-on-neutral-overlay pattern across themes. Shared overlay colors use a 60% black scrim and fall back to white when a high-contrast or e-ink token cannot provide 3:1 contrast, including over white cover artwork. This also covers book selection within shelves and download placeholder cards.
Testing
tools/papyrus check client: formatting, analyzer, and all 17 web utility tests passed.flutter pub get --enforce-lockfileand analyzer passed with the pinned Flutter SDK.UI evidence
Flutter widget-renderer captures at 188 × 300 logical pixels per card, 2× pixel ratio, with real fonts and shadows enabled. Columns show a favorite book, selected book, selected download, and shelf. These are component renders, not native-device acceptance screenshots.
High-contrast light · High-contrast dark · E-ink theme
Compatibility and migration
No migrations or dependency changes. The existing local reader override and lockfile edit are excluded.
Notes
Full-suite/browser CI and native-device acceptance are separate from the focused local checks. Whole-app accessibility verification remains outside this card-specific change.
Checklist