Skip to content

fix: improve card separation and overlay contrast - #128

Merged
Eoic merged 1 commit into
developmentfrom
fix/card-theme-contrast
Nov 6, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/card-theme-contrast

Conversation

@Eoic

@Eoic Eoic commented Nov 6, 2026

Copy link
Copy Markdown
Member

Issue and requirements

Closes #127. Covers the card-specific portions of NFR-5_1 (design system) and NFR-5_2 (accessibility).

Summary

Book and shelf cards blend into the page in dark mode, and favorite/selection icons lose contrast against their gray overlays in light mode. Use a subtle gray elevation shadow for dark book and shelf cards, plus pale theme colors for light-mode overlay icons.

Keep the same colored-icon-on-neutral-overlay pattern across themes. Shared overlay colors use a 60% black scrim and fall back to white when a high-contrast or e-ink token cannot provide 3:1 contrast, including over white cover artwork. This also covers book selection within shelves and download placeholder cards.

Testing

  • tools/papyrus check client: formatting, analyzer, and all 17 web utility tests passed.
  • 166 focused tests passed in both the working checkout with its existing local reader override and an isolated checkout using the committed reader Git pin.
  • Clean checkout: flutter pub get --enforce-lockfile and analyzer passed with the pinned Flutter SDK.
  • 25 new widget regressions inspect actual favorite/selection colors over white, black, red, green, and blue cover backgrounds across light, dark, both high-contrast themes, and e-ink. Existing tests cover selection semantics, callbacks, keyboard controls, shelf flows, and responsive layouts.

UI evidence

Flutter widget-renderer captures at 188 × 300 logical pixels per card, 2× pixel ratio, with real fonts and shadows enabled. Columns show a favorite book, selected book, selected download, and shelf. These are component renders, not native-device acceptance screenshots.

Light theme

Dark theme

High-contrast light · High-contrast dark · E-ink theme

Compatibility and migration

No migrations or dependency changes. The existing local reader override and lockfile edit are excluded.

Notes

Full-suite/browser CI and native-device acceptance are separate from the focused local checks. Whole-app accessibility verification remains outside this card-specific change.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the agreed scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and focused tests pass.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Keep book and shelf shadows visible in dark mode and preserve readable favorite and selection icons across cover colors and theme variants. Closes #127.
Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T14:51:03.001919Z 4375764 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/lib/themes/card_overlay_colors.dart 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit 6c4106f into development Nov 6, 2026
7 checks passed
@Eoic
Eoic deleted the fix/card-theme-contrast branch November 6, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve card separation and overlay icon contrast across themes

2 participants