Repository navigation
fix: preserve timer controls across load failures and conflicts - #132
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
A failed initial timer read could acknowledge and erase pending background controls. A concurrent native action could also survive rejection of an older action batch and be applied to a newer remote timer version. Keep replay unavailable until timer state loads successfully, and retain successor actions only when the acknowledged session and version match the committed action on Android and iOS.
Closes #131. Addresses the two current review findings on #130. Related requirements: FR-5_1 (PapyrusReader/docs#34), FR-5_3 (PapyrusReader/docs#36), FR-6_3 (PapyrusReader/docs#39).
Validation: both new regressions failed before their fixes. All 66 focused Dart tests and all five native iOS XCTest cases pass, including retaining valid concurrent actions and rejecting stale successors. The full Flutter suite passes with 2,216 tests and 19 skips against the committed Git reader pin. Analysis, formatting, all 17 web utility tests, and the Android direct debug build pass. Tests use synthetic data and an isolated iOS simulator. Hosted CI is pending. Physical-device acceptance was not run.