Skip to content

Replace vendored unrar_file with a pinned Papyrus fork - #135

Merged
Eoic merged 1 commit into
developmentfrom
fix/unrar-git-dependency
Nov 7, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/unrar-git-dependency

Conversation

@Eoic

@Eoic Eoic commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

The client currently owns a patched third-party package under packages/unrar_file. Move that maintenance to PapyrusReader/unrar_file, pin commit c3ad6a4ac4c732f081b9262bbf6b95ee2c1f5759 in both dependency files, and remove the vendored copy and obsolete CI path filters. The client README links to the fork's patch and update policy.

This is dependency maintenance; application code, versions, and archive behavior are unchanged. All 13 implementation/build files match the former copy (only iOS whitespace differs). The fork preserves the release-era upstream ancestry and adds plugin channel tests and CI. Existing RAR5-only parsing limitations remain separate work.

Validation:

  • Locked dependency resolution passed; only unrar_file changed source.
  • Client check commands passed in the isolated worktree: formatting (616 files), analysis (no issues), and 21 JavaScript tests.
  • Metadata tests: 10 passed, 8 skipped because external book fixtures are absent, including the CBR fixture.
  • Fork plugin tests: 2 passed locally; fork CI passed.
  • flutter build apk --debug --flavor play --no-pub passed locally with the pinned fork. SDK XML and Java source/target deprecation warnings remain.
  • Client CI is still running; no signed release or deployment is included.

@Eoic
Eoic marked this pull request as ready for review November 7, 2026 21:10
Copilot AI balanced review requested due to automatic review settings November 7, 2026 21:10
@Eoic
Eoic enabled auto-merge November 7, 2026 21:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T21:12:00.272813Z 75868f9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit 4d52e64 into development Nov 7, 2026
10 checks passed
@Eoic
Eoic deleted the fix/unrar-git-dependency branch November 7, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants