Repository navigation
fix(core): restart affected nodes after core deletion - #934
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks, merged. Capturing the affected nodes before the delete was exactly what was missing, and clearing |
Summary
ON DELETE SET NULLdoes not run.Verification
pytest tests/api/test_core.py tests/api/test_bulk_delete_entities.py -q— 32 passed (using the local SQLite test database).ruff check app/db/crud/core.py app/routers/core.py tests/api/test_bulk_delete_entities.py --no-fix— passed.ruff format --check app/db/crud/core.py app/routers/core.py tests/api/test_bulk_delete_entities.py— passed.Bulk deletion now reconnects affected active nodes automatically. Single deletion continues to honor the existing
restart_nodesoption.