Fix spectre buffs global effects applying just by existing in the spectre library#9667
Open
nofate121 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix spectre buffs global effects applying just by existing in the spectre library#9667nofate121 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
nofate121 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
e2ca9ba to
3a7ea61
Compare
Contributor
Author
|
Fixed some spelling errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9539, #8444 .
Description of the problem being solved:
Currently if one wants to get the benefits of normal Forest Warrior Culling Strike, it has to be an active gem slot and included in Full DPS. That is clear even from the information in the spectre libarary which says:
But the Onslaught buff of the Perfect Forest Warrior gets applied just by being in the spectre library (and having a different spectre used in a spectre gem). Creators already add the gem setup multiple times anyway, because of the non-global skills not applying otherwise. With this pr, the same is true for global effects from spectres.
For example Ghazzy added the line in his spectre build low budget setup, because they are only used in medium budget version loadout, but are still applying the buff in the low budget loadout.
Related to #9306.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/gIkEH3oU8iRe
Before screenshot:
After screenshot: