fix: ensure workflows checkout exact tag for clean version detection#110
Open
sameeul wants to merge 1 commit intoPolusAI:masterfrom
Open
fix: ensure workflows checkout exact tag for clean version detection#110sameeul wants to merge 1 commit intoPolusAI:masterfrom
sameeul wants to merge 1 commit intoPolusAI:masterfrom
Conversation
- Add ref: ${{ github.ref }} to checkout action to ensure we're on the exact tag
- Add git state verification step to confirm we're on exact tag
- Add setuptools-scm verification to display detected version in logs
This fixes the issue where setuptools-scm was detecting 2.2.2.post1.dev0
instead of clean 2.2.2 because the checkout wasn't at the exact tag commit.
With this fix, wheels will be built with clean version numbers (e.g., 2.2.2)
instead of post-release dev versions (e.g., 2.2.2.post1.dev0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where setuptools-scm was detecting 2.2.2.post1.dev0 instead of clean 2.2.2 because the checkout wasn't at the exact tag commit.
With this fix, wheels will be built with clean version numbers (e.g., 2.2.2) instead of post-release dev versions (e.g., 2.2.2.post1.dev0).