Repository navigation
Release item settings, expiry report and notification setup fixes - #1219
Merged
Merged
Conversation
Add product expiry reminders to core inventory
Fix active branch lookup for expiry notification bell
Group item settings, add expiry report and fix notification setup feedback
sridharkalaibala
changed the title
sridharcriteria
previously approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote core item expiry reminders, grouped Item settings, and the dedicated Expiry report from develop to main.
Item settings now groups stock preference and expiry reminders on the Inventory module page. The expiry report works independently of reminders and provides product search, date horizon, status filters, expiry sorting and pagination. Results respect branch permissions and shop timezone and exclude zero-stock products and invalid expiry dates.
Device notification setup now shows progress, explains permission and registration failures, and re-registers existing browser subscriptions with the server. Test notifications target the current device and no longer report success when none were delivered. Actual OS push delivery remains unverified in the built-in browser.
Validation: all checks passed on feature PRs #1218, #1220 and #1221; local root suite passed 4,106 tests with two skips; five real-database expiry tests passed. Built-in browser testing verified settings persistence and report search, status filters and sorting on the isolated develop site.
Develop preview: https://basket-review-test.posnic.com/public/dashboard.html#/expiryreport
Production deployment will use a fresh build of merged main after approval and merge, followed by live verification. The existing Basket Review extension does not need reinstallation.