Repository navigation
Make restock supplier search safe and align the dialog - #1227
Merged
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restock supplier selector is searchable, and core navigation shortcuts now ignore open dialogs, open searchable dropdowns and focused editors. Typing supplier names cannot navigate away from the restock basket. The dialog has aligned quantity controls, a touch-sized supplier picker, proper spacing below it and equal-width finish actions.
Validation: 17 local shortcut/restock tests passed; frontend build, formatting, diff and attribution checks passed. On the isolated demo, typed supplier and g using keyboard events and verified the page remained on Low Stock; Enter selected General Supplier. Matching/no-match search and supplier/item/quantity purchase handoff were also verified. Production unchanged.