Repository navigation
Load sales shelves on demand and distinguish category illustrations - #1234
Merged
Merged
Conversation
Release paginated sales catalogue and category illustrations
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sales shelf previously downloaded the entire catalogue before displaying its first 48 tiles. Fetch one server page at a time for Items and category browsing, keep variant families together, and use the full-catalogue search endpoint for names and barcodes. Ignore stale page responses and keep existing products visible while loading or retrying a page.
Category tiles also receive distinct illustrations for 66 retail labels, with uploaded images retaining priority.
Validation: 4,125 local tests passed, 2 skipped; two additional real-MongoDB tests passed for page boundaries, scope, variant families, and barcode lookup beyond page one. API controller/repository unit tests (305), language checks (57), frontend build, lint and attribution checks passed. Staging browser network inspection confirmed one page request on Next, plus successful search for an unloaded item and category navigation.