Skip to content

Fix Captain discovery for legacy and shared branches - #1253

Merged
sridharkalaibala merged 1 commit into
developfrom
codex/captain-cloud-discovery-20261008
Oct 13, 2026
Merged

sridharkalaibala merged 1 commit into
developfrom
codex/captain-cloud-discovery-20261008

Conversation

@sridharkalaibala

Copy link
Copy Markdown
Contributor

Captain discovery returned no shop details for legacy branches whose Captain switch was unset, and for tills serving several branches. Match the existing Captain access defaults, return the enabled branch display names, and include the Internet address only when all enabled branches share it.

Validation: three focused API tests passed. The handler was also tested read-only against the local GSHCL branch data, then the approved local update was restarted and its live discovery endpoint returned the names and shared Internet address. No staff details or branch IDs are returned.

@sridharkalaibala
sridharkalaibala merged commit d88123b into develop Oct 13, 2026
8 of 11 checks passed
@github-actions github-actions Bot added the ready for QA Merged to develop and live on develop.posnic.io - anyone can test it label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QA Merged to develop and live on develop.posnic.io - anyone can test it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant