Skip to content

Group Sales History filters and add searchable staff/device choices - #1255

Merged
sridharkalaibala merged 2 commits into
developfrom
codex/compact-history-filters
Oct 11, 2026
Merged

sridharkalaibala merged 2 commits into
developfrom
codex/compact-history-filters

Conversation

@sridharkalaibala

Copy link
Copy Markdown
Contributor

Sales History showed staff/device text inputs separately from its main filters, leaving users to guess existing names or device IDs. Group all controls under one Filter button and provide searchable dropdowns populated from up to ten matching recorded values in the selected branch.

The panel has one Apply/Clear all flow and removable applied-filter chips. Opening a dropdown preserves its selection. Retail uses Staff rather than Order taken by; table/serving-period fields remain restaurant-only, and source choices follow the existing feature gates. The dropdown API checks sales-read permission and branch/tenant access.

Validation: 167 controller tests, 13 Sales History tests, and 3 real-MongoDB filter-option tests passed. API lint, syntax checks, attribution checks and diff whitespace checks passed. The installed GSHCL EXE has not been rebuilt for this change.

@sridharkalaibala
sridharkalaibala merged commit e7f7da1 into develop Oct 11, 2026
9 of 11 checks passed
@github-actions github-actions Bot added the ready for QA Merged to develop and live on develop.posnic.io - anyone can test it label Oct 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QA Merged to develop and live on develop.posnic.io - anyone can test it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant