Repository navigation
Group Sales History filters and add searchable staff/device choices - #1255
Merged
Merged
Conversation
Signed-off-by: Sridhar Bala <sridharkalaibala@gmail.com>
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sales History showed staff/device text inputs separately from its main filters, leaving users to guess existing names or device IDs. Group all controls under one Filter button and provide searchable dropdowns populated from up to ten matching recorded values in the selected branch.
The panel has one Apply/Clear all flow and removable applied-filter chips. Opening a dropdown preserves its selection. Retail uses Staff rather than Order taken by; table/serving-period fields remain restaurant-only, and source choices follow the existing feature gates. The dropdown API checks sales-read permission and branch/tenant access.
Validation: 167 controller tests, 13 Sales History tests, and 3 real-MongoDB filter-option tests passed. API lint, syntax checks, attribution checks and diff whitespace checks passed. The installed GSHCL EXE has not been rebuilt for this change.