Repository navigation
Fix customer transaction heading reusing lang_Addexpensing key - #1258
Tyagiquamar wants to merge 1 commit into
Conversation
…xpensing key Signed-off-by: Abhipsita-coder <76418226+Abhipsita-coder@users.noreply.github.com>
|
Thank you for this. Before it can be merged we need a one-line signature on our Contributor Licence Agreement. You keep the copyright in your work; the agreement lets Posnic ship your contribution in the paid edition alongside the AGPL release. To sign, reply to this pull request with exactly: I have read the CLA document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
sridharkalaibala
left a comment
There was a problem hiding this comment.
Thanks for fixing this heading. I checked the one-line diff and reproduced the two desktop i18n failures locally with node --test tests/i18n.test.js (49 passed, 2 failed). The existing lang_customer_title means plural Customers, while this heading says singular Customer, so reusing it still violates the one-key/one-meaning rule. Please use a singular customer key with matching meaning (or add a dedicated key), update the English inventory with node tests/tools/i18n-coverage.js --write-english, and rerun the full i18n suite. The inventory also retains the now-unused lang_Addexpensing key. git diff --check passed. The CLA check is still pending your signature as described by the bot. Once these checks are green, this focused correction can be reconsidered.
Issue #446: the customer transaction heading reused
lang_Addexpensing, which is meant to read "Customer" on the customer screen but collided with the expense modal's "Add" meaning. Switch the customer heading to the existinglang_customer_titlekey. i18n coverage stays clean (exit 0).