fix(folder-picker): show loading state to fix dead clicks on repo selector

[adboio]

Problem

Clicking the folder/repo selector opens a native directory picker dialog, but the UI gave no synchronous feedback while the dialog was open. Because no DOM mutation occurred on click, PostHog logged these as "dead clicks." Users also had no indication that the picker was opening.

Changes

• Add an isOpening state to FolderPicker that is set synchronously when the picker is triggered and cleared in a finally block once the native dialog resolves or errors.
• While opening:
  • Display "Opening..." text in both the field and compact variants.
  • Swap the CaretDown icon for an animated CircleNotch spinner.
  • Disable the trigger and set aria-busy to prevent re-clicks and improve accessibility.
• Guard handleOpenFilePicker to ignore re-clicks while a dialog is already open.
• Add FolderPicker.test.tsx covering:
  • Synchronous "Opening..." feedback and disabled state while the dialog is open, followed by committing the selected path.
  • Ignoring re-clicks while a dialog is already in flight.

The synchronous state change both reassures the user and gives PostHog a DOM mutation so the open native dialog is no longer recorded as a dead click.

How did you test this?

• Added unit tests with Vitest / Testing Library verifying the loading state, path commit, and re-click guard behavior.

Automatic notifications

• Publish to changelog?
• Alert Sales and Marketing teams?

---

Created with PostHog Code

[greptile-apps]

Comments Outside Diff (1)

1. apps/code/src/renderer/features/folder-picker/components/FolderPicker.tsx, line 137-185 (link)

   isOpening protection incomplete for the dropdown path

   When recentFolders.length > 0 the component renders a DropdownMenu. The DropdownMenuTrigger (lines 139–151) and the "Open folder..." DropdownMenuItem (line 179) neither receive disabled={isOpening} nor aria-busy={isOpening}. While the if (isOpening) return guard prevents a second dialog from opening, the dropdown itself is still openable mid-flight, so a user can click the trigger, see the dropdown appear, and attempt the "Open folder..." item — at which point nothing happens silently. The visual loading state (spinner, "Opening..." text) is present in the trigger content, but the button is not actually disabled, making the accessibility and UX fix described in the PR incomplete for this branch.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: apps/code/src/renderer/features/folder-picker/components/FolderPicker.tsx
   Line: 137-185
   
   Comment:
   **`isOpening` protection incomplete for the dropdown path**
   
   When `recentFolders.length > 0` the component renders a `DropdownMenu`. The `DropdownMenuTrigger` (lines 139–151) and the "Open folder..." `DropdownMenuItem` (line 179) neither receive `disabled={isOpening}` nor `aria-busy={isOpening}`. While the `if (isOpening) return` guard prevents a second dialog from opening, the dropdown itself is still openable mid-flight, so a user can click the trigger, see the dropdown appear, and attempt the "Open folder..." item — at which point nothing happens silently. The visual loading state (spinner, "Opening..." text) is present in the trigger content, but the button is not actually disabled, making the accessibility and UX fix described in the PR incomplete for this branch.
   
   How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/code/src/renderer/features/folder-picker/components/FolderPicker.tsx:137-185
**`isOpening` protection incomplete for the dropdown path**

When `recentFolders.length > 0` the component renders a `DropdownMenu`. The `DropdownMenuTrigger` (lines 139–151) and the "Open folder..." `DropdownMenuItem` (line 179) neither receive `disabled={isOpening}` nor `aria-busy={isOpening}`. While the `if (isOpening) return` guard prevents a second dialog from opening, the dropdown itself is still openable mid-flight, so a user can click the trigger, see the dropdown appear, and attempt the "Open folder..." item — at which point nothing happens silently. The visual loading state (spinner, "Opening..." text) is present in the trigger content, but the button is not actually disabled, making the accessibility and UX fix described in the PR incomplete for this branch.

### Issue 2 of 2
apps/code/src/renderer/features/folder-picker/components/FolderPicker.tsx:53-55
The string `"Opening..."` is spelled out twice — once in `fieldContent` and once in `compactContent` — violating the OnceAndOnlyOnce simplicity rule. Extracting it to a constant makes any future copy change a single edit.

```suggestion
  const [isOpening, setIsOpening] = useState(false);
  const openingLabel = "Opening...";

  const handleSelect = (path: string) => {
```

_{Reviews (1): Last reviewed commit: "feat(folder-picker): show loading state ..." | Re-trigger Greptile}

[greptile-apps]

The string "Opening..." is spelled out twice — once in fieldContent and once in compactContent — violating the OnceAndOnlyOnce simplicity rule. Extracting it to a constant makes any future copy change a single edit.

Suggested change

	const [isOpening, setIsOpening] = useState(false);
	const handleSelect = (path: string) => {
	const [isOpening, setIsOpening] = useState(false);
	const openingLabel = "Opening...";
	const handleSelect = (path: string) => {

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/folder-picker/components/FolderPicker.tsx
Line: 53-55

Comment:
The string `"Opening..."` is spelled out twice — once in `fieldContent` and once in `compactContent` — violating the OnceAndOnlyOnce simplicity rule. Extracting it to a constant makes any future copy change a single edit.

```suggestion
  const [isOpening, setIsOpening] = useState(false);
  const openingLabel = "Opening...";

  const handleSelect = (path: string) => {
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[stamphog]

Review agent failed after 3 attempts — needs human review.