Skip to content

feat(inbox): configurable base branch for inbox auto-PRs#2480

Open
tatoalo wants to merge 1 commit into
mainfrom
feat/cloud-agent/inbox-branch-switcher
Open

feat(inbox): configurable base branch for inbox auto-PRs#2480
tatoalo wants to merge 1 commit into
mainfrom
feat/cloud-agent/inbox-branch-switcher

Conversation

@tatoalo
Copy link
Copy Markdown
Contributor

@tatoalo tatoalo commented Jun 4, 2026

Summary

adding configurable base branch for auto-PRs setting so inbox-driven cloud tasks can target a chosen branch (renderer side of #2470)

configurable_base

@tatoalo tatoalo self-assigned this Jun 4, 2026
@tatoalo tatoalo marked this pull request as ready for review June 4, 2026 09:15
@tatoalo tatoalo requested a review from a team June 4, 2026 09:16
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 4, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/inbox/hooks/useCreatePrReport.ts:107-111
The two-step lookup normalises only the *lookup* key, not the *stored* key. If the map entry was stored with uppercase letters (e.g. `MyOrg/MyRepo`) and `cloudRepository` arrives in lowercase, both lookups miss and the PR silently falls back to the repo default. Storing and looking up with a single canonical form (e.g. always `toLowerCase()`) would make the behaviour unambiguous. The current fallback is safe but the asymmetry could cause a confusing "setting has no effect" situation if casing diverges between the UI's source and the report's `cloudRepository`.

```suggestion
    const baseBranchOverrides = autonomyConfig?.autostart_base_branches ?? {};
    const baseBranch =
      baseBranchOverrides[cloudRepository] ??
      baseBranchOverrides[cloudRepository.toLowerCase()] ??
      baseBranchOverrides[
        Object.keys(baseBranchOverrides).find(
          (k) => k.toLowerCase() === cloudRepository.toLowerCase(),
        ) ?? ""
      ] ??
      null;
```

Reviews (1): Last reviewed commit: "feat(inbox): configurable base branch fo..." | Re-trigger Greptile

Comment thread apps/code/src/renderer/features/inbox/hooks/useCreatePrReport.ts Outdated
@tatoalo tatoalo force-pushed the feat/cloud-agent/inbox-branch-switcher branch 2 times, most recently from efb829e to 2265a64 Compare June 4, 2026 10:35
@tatoalo tatoalo force-pushed the feat/cloud-agent/inbox-branch-switcher branch from 2265a64 to a1fe16a Compare June 4, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant