feat(inbox): configurable base branch for inbox auto-PRs#2480
Open
tatoalo wants to merge 1 commit into
Open
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/inbox/hooks/useCreatePrReport.ts:107-111
The two-step lookup normalises only the *lookup* key, not the *stored* key. If the map entry was stored with uppercase letters (e.g. `MyOrg/MyRepo`) and `cloudRepository` arrives in lowercase, both lookups miss and the PR silently falls back to the repo default. Storing and looking up with a single canonical form (e.g. always `toLowerCase()`) would make the behaviour unambiguous. The current fallback is safe but the asymmetry could cause a confusing "setting has no effect" situation if casing diverges between the UI's source and the report's `cloudRepository`.
```suggestion
const baseBranchOverrides = autonomyConfig?.autostart_base_branches ?? {};
const baseBranch =
baseBranchOverrides[cloudRepository] ??
baseBranchOverrides[cloudRepository.toLowerCase()] ??
baseBranchOverrides[
Object.keys(baseBranchOverrides).find(
(k) => k.toLowerCase() === cloudRepository.toLowerCase(),
) ?? ""
] ??
null;
```
Reviews (1): Last reviewed commit: "feat(inbox): configurable base branch fo..." | Re-trigger Greptile |
efb829e to
2265a64
Compare
chore: cleaner
2265a64 to
a1fe16a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adding configurable base branch for auto-PRs setting so inbox-driven cloud tasks can target a chosen branch (renderer side of #2470)