Fix Linux/bash compatibility in sequential tests#12
Merged
jnasbyupgrade merged 5 commits intoPostgres-Extensions:masterfrom Mar 25, 2026
Merged
Fix Linux/bash compatibility in sequential tests#12jnasbyupgrade merged 5 commits intoPostgres-Extensions:masterfrom
jnasbyupgrade merged 5 commits intoPostgres-Extensions:masterfrom
Conversation
Delete `pgxntool-test.source` which was left behind when .source support was removed in c30cdc5. Remove the "can copy expected output file to test/output" test from `make-test.bats` that referenced it. Changes only in pgxntool-test. No related changes in pgxntool. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- `03-setup-final.bats`: replace BSD-only `sed -i ''` with portable `sed -i.bak` + `rm`; commit `deps.sql` after updating so repo stays clean on subsequent runs (removes stale skip) - `04-pgtle.bats`: use GNU-first `stat -c %Y` with BSD `stat -f %m` fallback for mtime checks Companion to pgxntool d472ba3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Avoids hardcoding /bin/bash which breaks on systems where bash lives elsewhere (some BSDs, NixOS, Homebrew on macOS). Documents the rule in CLAUDE.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Mar 25, 2026
Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#12 ## Changes **bash 3.2 syntax fix (`pgtle.sh`)** - Replace `${#ARRAY[@]:-0}` with `${#ARRAY[@]}` throughout `pgtle.sh` - `${#ARRAY[@]:-0}` is a fatal syntax error ("bad substitution") in bash 3.2 — the `:-` default modifier cannot be applied to an array length expression - `${#ARRAY[@]}` correctly returns 0 for empty arrays in all bash versions **DOCS deduplication (`base.mk`)** - Deduplicate `DOCS` when adding generated HTML, preventing duplicate install entries when HTML is already included by the wildcard **Shebang portability (all shell scripts)** - Replace `#!/bin/bash` with `#!/usr/bin/env bash` in `pgtle.sh`, `build_meta.sh`, and `lib.sh` - `/bin/bash` fails on systems where bash lives elsewhere (some BSDs, NixOS, Homebrew on macOS)
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Mar 25, 2026
Resolve conflicts from upstream's Linux/bash compatibility fix (Postgres-Extensions#12): - CLAUDE.md: keep both Template Requirements and Shell Script Standards sections - .claude/settings.json: merge permissions (add run-tests.sh, Skill(test); keep make/utility permissions; drop duplicates) - 03-setup-final.bats: keep setup_file() approach for deps.sql update, fix portability (sed -i.bak instead of BSD-only sed -i '') - make-test.bats: adopt upstream's simplified version (pgxntool-test.source deleted, no longer needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#23
Changes
03-setup-final.bats: portablesed+ clean repo statesed -i ''with portablesed -i.bak+rm;sed -i ''is valid on GNU sed but has different argument parsing — using-i.bakworks on bothdeps.sqlafter updating so the repo stays clean on subsequent test runs (eliminates the stale skip "deps.sql already updated")04-pgtle.bats: portablestatfor mtime checksstat -f %m(primary) with GNU-firststat -c %Ywith BSD fallbackShebang portability (scripts)
#!/bin/bashwith#!/usr/bin/env bashinbin/create-worktree.shand.claude/skills/scripts