Target folder is not created, even with -Force parameter. Git.ps1#99
Open
rcarboneras wants to merge 2 commits intoPowerShellOrg:masterfrom
Open
Target folder is not created, even with -Force parameter. Git.ps1#99rcarboneras wants to merge 2 commits intoPowerShellOrg:masterfrom
rcarboneras wants to merge 2 commits intoPowerShellOrg:masterfrom
Conversation
Author
|
I've made a minor change in the way of creating the folder: else |
There was a problem hiding this comment.
Pull request overview
This PR updates the Git dependency script to better handle cases where Dependency.Target does not exist, aiming to honor -Force by creating the target folder instead of silently cloning into the current directory.
Changes:
- Adds a
-Forcecode path intended to create the target folder whenDependency.Targetcannot be resolved. - Adjusts how
$Targetis computed in the “target missing/unresolvable” branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+96
to
+104
| if ($Force) { | ||
| New-Item -ItemType Directory -Name (Split-Path $Dependency.Target -Leaf) -Force | Out-Null | ||
| Write-Debug "Target folder $($Dependency.Target) created as -Force switch was specified" | ||
| $Target = Join-Path $PWD "$(Split-Path $Dependency.Target -Leaf)" | ||
| } | ||
| else { | ||
| $Target = $PWD.Path | ||
| Write-Debug "Target defaulted to current dir: $Target" | ||
| } |
Comment on lines
+96
to
+104
| if ($Force) { | ||
| New-Item -ItemType Directory -Name (Split-Path $Dependency.Target -Leaf) -Force | Out-Null | ||
| Write-Debug "Target folder $($Dependency.Target) created as -Force switch was specified" | ||
| $Target = Join-Path $PWD "$(Split-Path $Dependency.Target -Leaf)" | ||
| } | ||
| else { | ||
| $Target = $PWD.Path | ||
| Write-Debug "Target defaulted to current dir: $Target" | ||
| } |
Comment on lines
+96
to
+104
| if ($Force) { | ||
| New-Item -ItemType Directory -Name (Split-Path $Dependency.Target -Leaf) -Force | Out-Null | ||
| Write-Debug "Target folder $($Dependency.Target) created as -Force switch was specified" | ||
| $Target = Join-Path $PWD "$(Split-Path $Dependency.Target -Leaf)" | ||
| } | ||
| else { | ||
| $Target = $PWD.Path | ||
| Write-Debug "Target defaulted to current dir: $Target" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a Git repository, if target doesn't exist, the dependency is downloaded in the current directory and the error is silenced, affecting the path sctructure of your proyect. Unless you check the $Errors variable, you'll never now what is happening.
However, when using PowerShell Gallery, the bellow piece of code does the work in the Save-Module function:
When -Force is specified, Path will be created if not available
I propose then to implement the same behaviour in Git.ps1 script with the following lines:
else$PWD "$ ($Dependency.Target)"
{
if ($Force) {New-Item -ItemType Directory -Name $Dependency.Target -Force | Out-Null
Write-Debug "Target folder $($Dependency.Target) created as -Force switch was specified"
$Target = Join-Path
}
else {
$Target = $PWD.Path
Write-Debug "Target defaulted to current dir: $Target"
}
}