Repository navigation
ENG-8503: add --yes to prime train stop - #1207
Merged
Merged
Conversation
Co-authored-by: JannikSt <JannikSt@users.noreply.github.com>
JannikSt
requested review from
DamianB-BitFlipper,
JohannesHa,
akirillo,
burnpiro,
cabrinha,
eexwhyzee,
kcoopermiller,
kennethnym,
mrmoxon and
willccbb
as code owners
November 19, 2026 04:53
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: JannikSt <JannikSt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
-y/--yestoprime train stopto skip the confirmation prompt, so scripts no longer needprintf 'y\n' |. It followsprime inference deployments delete: same option (--yes,-y), same help text (Skip confirmation), and the sameconfirm_or_skiphelper.stopalready had-f/--forcewith the same effect. It's kept, so existing scripts keep working.Are you sure you want to stop run <id>? [y/N]prompt, defaulting to No.Other
prime traincommands that confirmThese were left unchanged in this PR:
prime train <config>(run)--yes/-yprime train resume--yes/-yprime train delete--force/-fonlyprime train pause--force/-fonlyprime train restart--force/-fonlydelete,pauseandrestartuse the same--force-plus-typer.confirmpatternstophad, so each could get--yesthe same way in a follow-up.Tests
New tests in
tests/test_train_cli.py:--yes,-y,--forceor-f, no prompt is shown andPUT /rft/runs/run-1/stopis called.[y/N]prompt is shown. Answeringystops the run;nor a bare Enter printsCancelled.and makes no API call.--helplists--yes -y Skip confirmation.Checks run:
ruff check,ruff format --check,ty check src/, and the fullpackages/primesuite (1970 passed).Note
Low Risk
CLI-only confirmation UX change with no API or auth impact; existing --force behavior is preserved.
Reviewed by Cursor Bugbot for commit 56c39cf. Bugbot is set up for automated code reviews on this repo. Configure here.