Repository navigation
Conversation
This was referenced Nov 19, 2026
xeophon
marked this pull request as ready for review
November 19, 2026 01:13
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Claude Code rollouts now explicitly use manual permission routing through ACP, while intercepted runs continue requesting approval for every tool. Trace-local configuration and the unchanged gate handling keep the change narrowly scoped. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
xeophon
force-pushed
the
codex/3205-claude-permissions
branch
from
November 19, 2026 01:30
91f25f7 to
d4077c4
Compare
xeophon
force-pushed
the
codex/3205-mediated-replay
branch
from
November 19, 2026 01:30
97a1b67 to
cc9d178
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set Claude Code’s default permission mode to Manual for rollouts. When tool interception is enabled, continue requesting approval for every tool. This routes decisions through ACP and avoids the separate Auto classifier.
Local unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes
Layer 4 of 13. Builds on #3210. Stack index
Note
Use manual tool approvals for Claude Code harness rollouts
CLAUDE_PERMISSIONSconfig withdefaultModeset todefaultin harness.pysettings.jsonwith these permissions under the trace-specific config directory before installing skillsClaudeCodeHarness.gate_toolsmergesCLAUDE_PERMISSIONSwith theaskrule for all tools, instead of writing only theaskruledefaultModealongside the per-toolaskrules; checkgate_toolsand thesettings.jsonoutput if you relied on the previous ask-only configurationMacroscope summarized d4077c4.
Note
Medium Risk
Changes how Claude Code permission settings are written for every rollout and for tool gating, which affects which tools run without extra approval.
Overview
Claude Code harness rollouts now set a shared
CLAUDE_PERMISSIONSwithdefaultMode: "default"(manual approvals via ACP) instead of relying on ask-only or auto behavior.prepare_acpwrites tracesettings.jsonwith those permissions before skills install so every session starts in that mode. When tool interception runs,gate_toolsstill appliesask: ["*"]but merges it withCLAUDE_PERMISSIONSrather than overwriting permissions with ask rules alone.Reviewed by Cursor Bugbot for commit d4077c4. Bugbot is set up for automated code reviews on this repo. Configure here.