Skip to content

Use manual tool approvals for Claude Code rollouts - #3211

Open
xeophon wants to merge 1 commit into
codex/3205-mediated-replayfrom
codex/3205-claude-permissions
Open

xeophon wants to merge 1 commit into
codex/3205-mediated-replayfrom
codex/3205-claude-permissions

Conversation

@xeophon

@xeophon xeophon commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Set Claude Code’s default permission mode to Manual for rollouts. When tool interception is enabled, continue requesting approval for every tool. This routes decisions through ACP and avoids the separate Auto classifier.

Local unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes

Layer 4 of 13. Builds on #3210. Stack index

Note

Use manual tool approvals for Claude Code harness rollouts

  • Adds a shared CLAUDE_PERMISSIONS config with defaultMode set to default in harness.py
  • The ACP config builder now writes settings.json with these permissions under the trace-specific config directory before installing skills
  • ClaudeCodeHarness.gate_tools merges CLAUDE_PERMISSIONS with the ask rule for all tools, instead of writing only the ask rule
  • Behavioral Change: tool-approval settings now include the defaultMode alongside the per-tool ask rules; check gate_tools and the settings.json output if you relied on the previous ask-only configuration

Macroscope summarized d4077c4.


Note

Medium Risk
Changes how Claude Code permission settings are written for every rollout and for tool gating, which affects which tools run without extra approval.

Overview
Claude Code harness rollouts now set a shared CLAUDE_PERMISSIONS with defaultMode: "default" (manual approvals via ACP) instead of relying on ask-only or auto behavior.

prepare_acp writes trace settings.json with those permissions before skills install so every session starts in that mode. When tool interception runs, gate_tools still applies ask: ["*"] but merges it with CLAUDE_PERMISSIONS rather than overwriting permissions with ask rules alone.

Reviewed by Cursor Bugbot for commit d4077c4. Bugbot is set up for automated code reviews on this repo. Configure here.

@macroscopeapp

macroscopeapp Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 91f25f7

Macroscope's review found this PR approvable — Claude Code rollouts now explicitly use manual permission routing through ACP, while intercepted runs continue requesting approval for every tool. Trace-local configuration and the unchanged gate handling keep the change narrowly scoped.

No code changes detected at d4077c4. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@xeophon
xeophon force-pushed the codex/3205-claude-permissions branch from 91f25f7 to d4077c4 Compare November 19, 2026 01:30
@xeophon
xeophon force-pushed the codex/3205-mediated-replay branch from 97a1b67 to cc9d178 Compare November 19, 2026 01:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant