Skip to content

Suppress Codex title and follow-up model calls during rollouts - #3213

Open
xeophon wants to merge 1 commit into
codex/3205-codex-installerfrom
codex/3205-codex-background
Open

xeophon wants to merge 1 commit into
codex/3205-codex-installerfrom
codex/3205-codex-background

Conversation

@xeophon

@xeophon xeophon commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Name the ACP session before its first prompt and turn off interactive follow-up suggestions. The title-generation request sent a developer additional_tools catalog as Responses input[0]. Removing that item made the internal provider return HTTP 200. Adding it to a one-line request reproduced the HTTP 400. Verified against both shipped pairs: Codex 0.166.0 with ACP 2.5.0, and Codex 0.170.0 with ACP 2.7.0. In each case the Verifiers ACP runner started a fresh session and received a matching session_info_update with the requested title before its first prompt. The Python SDK adds the leading underscore when it sends the adapter’s _session/rename extension. Controlled provider comparison

Local unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes

Layer 6 of 13. Builds on #3212. Stack index

Note

Add ACP session title and disable Codex follow-up prompt suggestions

  • Adds an optional session_title field to ACPConfig; ACPSession.start in runner.py renames the session via the session/rename extension when the title is set
  • CodexHarness sets the session title to the rollout trace ID and adds sessionIndex to the JetBrains Air client-capability list
  • Sets CODEX_ACP_PROMPT_SUGGESTIONS=false in the Codex process environment to suppress follow-up model calls
  • Risk: a failed rename during ACPSession.start now fails session startup after cleanup — check the rename call and its exception handler in runner.py

Macroscope summarized b290a99.


Note

Medium Risk
Session startup now depends on a successful session/rename call; failures abort startup after cleanup. Codex env/capability changes affect rollout model traffic and adapter behavior only.

Overview
Rollouts can name the ACP session up front and turn off Codex behaviors that trigger extra model calls before or after the real task.

Optional session_title on ACPConfig is passed into the ACP runner config. After new_session, the runner calls the session/rename extension when a title is set, so the session is titled before the first prompt instead of leaving Codex to run a separate title-generation turn.

Codex harness sets session_title to Verifiers rollout {trace.id}, adds sessionIndex to the JetBrains Air client capabilities list, and sets CODEX_ACP_PROMPT_SUGGESTIONS=false in the process environment so rollouts do not request interactive follow-up suggestions.

Reviewed by Cursor Bugbot for commit b290a99. Bugbot is set up for automated code reviews on this repo. Configure here.

@macroscopeapp

macroscopeapp Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at dd171ab

Macroscope's review found this PR approvable — Codex rollouts receive explicit session titles and disable suggested follow-ups, avoiding auxiliary model calls. The changes are confined to rollout configuration, with other ACP consumers unchanged by default.

No code changes detected at b290a99. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@xeophon
xeophon force-pushed the codex/3205-codex-installer branch from b07935a to daa9e47 Compare November 19, 2026 01:30
@xeophon
xeophon force-pushed the codex/3205-codex-background branch from dd171ab to b290a99 Compare November 19, 2026 01:30

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b290a99. Configure here.

Comment thread verifiers/v1/acp/runner.py Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant