Repository navigation
Conversation
This was referenced Nov 19, 2026
xeophon
marked this pull request as ready for review
November 19, 2026 01:13
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Codex rollouts receive explicit session titles and disable suggested follow-ups, avoiding auxiliary model calls. The changes are confined to rollout configuration, with other ACP consumers unchanged by default. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
xeophon
force-pushed
the
codex/3205-codex-installer
branch
from
November 19, 2026 01:30
b07935a to
daa9e47
Compare
xeophon
force-pushed
the
codex/3205-codex-background
branch
from
November 19, 2026 01:30
dd171ab to
b290a99
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b290a99. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Name the ACP session before its first prompt and turn off interactive follow-up suggestions. The title-generation request sent a developer
additional_toolscatalog as Responsesinput[0]. Removing that item made the internal provider return HTTP 200. Adding it to a one-line request reproduced the HTTP 400. Verified against both shipped pairs: Codex 0.166.0 with ACP 2.5.0, and Codex 0.170.0 with ACP 2.7.0. In each case the Verifiers ACP runner started a fresh session and received a matching session_info_update with the requested title before its first prompt. The Python SDK adds the leading underscore when it sends the adapter’s_session/renameextension. Controlled provider comparisonLocal unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes
Layer 6 of 13. Builds on #3212. Stack index
Note
Add ACP session title and disable Codex follow-up prompt suggestions
session_titlefield toACPConfig;ACPSession.startin runner.py renames the session via thesession/renameextension when the title is setsessionIndexto the JetBrains Air client-capability listCODEX_ACP_PROMPT_SUGGESTIONS=falsein the Codex process environment to suppress follow-up model callsACPSession.startnow fails session startup after cleanup — check the rename call and its exception handler in runner.pyMacroscope summarized b290a99.
Note
Medium Risk
Session startup now depends on a successful
session/renamecall; failures abort startup after cleanup. Codex env/capability changes affect rollout model traffic and adapter behavior only.Overview
Rollouts can name the ACP session up front and turn off Codex behaviors that trigger extra model calls before or after the real task.
Optional
session_titleonACPConfigis passed into the ACP runner config. Afternew_session, the runner calls thesession/renameextension when a title is set, so the session is titled before the first prompt instead of leaving Codex to run a separate title-generation turn.Codex harness sets
session_titletoVerifiers rollout {trace.id}, addssessionIndexto the JetBrains Air client capabilities list, and setsCODEX_ACP_PROMPT_SUGGESTIONS=falsein the process environment so rollouts do not request interactive follow-up suggestions.Reviewed by Cursor Bugbot for commit b290a99. Bugbot is set up for automated code reviews on this repo. Configure here.