Skip to content

Send Stirrup replies as typed ACP text updates - #3216

Open
xeophon wants to merge 1 commit into
codex/3205-openclaw-heartbeatfrom
codex/3205-stirrup-acp
Open

xeophon wants to merge 1 commit into
codex/3205-openclaw-heartbeatfrom
codex/3205-stirrup-acp

Conversation

@xeophon

@xeophon xeophon commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Construct the assistant’s ACP text update with AgentMessageChunk and TextContentBlock. ACP 1.0 removes the previous convenience function. This layer supplies both wire discriminators explicitly because ACP 0.12.1 requires them. The same typed update was verified against both SDK versions.

Local unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes

Layer 9 of 13. Builds on #3215. Stack index

Note

Send Stirrup ACP replies as typed agent message chunks

Replaces the generic ACP text-update helper in StirrupACPAgent.prompt with a direct construction of an agent message chunk containing the reply as a text content block. Updates imports in program.py to use the message-chunk and text-content schemas.

Macroscope summarized d9f718a.


Note

Low Risk
Narrow protocol-wiring change in the Stirrup ACP harness with no auth, data, or security impact.

Overview
Replaces the removed ACP helper update_agent_message_text in the Stirrup harness with an explicit AgentMessageChunk carrying a TextContentBlock when streaming the assistant reply over session_update.

Imports drop the convenience API from acp and pull the message-chunk and text-content types from acp.schema, so wire discriminators are set explicitly for compatibility across pinned ACP SDK versions (0.12.1 and 1.0).

Reviewed by Cursor Bugbot for commit d9f718a. Bugbot is set up for automated code reviews on this repo. Configure here.

@macroscopeapp

macroscopeapp Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 80c1fbc

Macroscope's review found this PR approvable — Stirrup replies now use explicit typed ACP text-update objects instead of the helper. The reply content and destination remain unchanged, with risk limited to the existing response-serialization boundary.

No code changes detected at d9f718a. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@xeophon
xeophon force-pushed the codex/3205-stirrup-acp branch from 80c1fbc to d9f718a Compare November 19, 2026 01:30
@xeophon
xeophon force-pushed the codex/3205-openclaw-heartbeat branch from 13065f5 to 2752ebf Compare November 19, 2026 01:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant