Repository navigation
Conversation
This was referenced Nov 19, 2026
xeophon
marked this pull request as ready for review
November 19, 2026 01:13
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Stirrup replies now use explicit typed ACP text-update objects instead of the helper. The reply content and destination remain unchanged, with risk limited to the existing response-serialization boundary. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
xeophon
force-pushed
the
codex/3205-stirrup-acp
branch
from
November 19, 2026 01:30
80c1fbc to
d9f718a
Compare
xeophon
force-pushed
the
codex/3205-openclaw-heartbeat
branch
from
November 19, 2026 01:30
13065f5 to
2752ebf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct the assistant’s ACP text update with
AgentMessageChunkandTextContentBlock. ACP 1.0 removes the previous convenience function. This layer supplies both wire discriminators explicitly because ACP 0.12.1 requires them. The same typed update was verified against both SDK versions.Local unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes
Layer 9 of 13. Builds on #3215. Stack index
Note
Send Stirrup ACP replies as typed agent message chunks
Replaces the generic ACP text-update helper in
StirrupACPAgent.promptwith a direct construction of an agent message chunk containing the reply as a text content block. Updates imports in program.py to use the message-chunk and text-content schemas.Macroscope summarized d9f718a.
Note
Low Risk
Narrow protocol-wiring change in the Stirrup ACP harness with no auth, data, or security impact.
Overview
Replaces the removed ACP helper
update_agent_message_textin the Stirrup harness with an explicitAgentMessageChunkcarrying aTextContentBlockwhen streaming the assistant reply oversession_update.Imports drop the convenience API from
acpand pull the message-chunk and text-content types fromacp.schema, so wire discriminators are set explicitly for compatibility across pinned ACP SDK versions (0.12.1 and 1.0).Reviewed by Cursor Bugbot for commit d9f718a. Bugbot is set up for automated code reviews on this repo. Configure here.