Repository navigation
Conversation
This was referenced Nov 19, 2026
xeophon
marked this pull request as ready for review
November 19, 2026 01:13
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Unexpected integration-trace forks now report the sibling nodes and differing field names. The change is confined to test-failure diagnostics and does not affect production behavior. Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
xeophon
force-pushed
the
codex/3205-network-fixture
branch
from
November 19, 2026 01:30
7e0ed60 to
ab7cdbe
Compare
xeophon
force-pushed
the
codex/3205-branch-diagnostics
branch
from
November 19, 2026 01:30
46c75d3 to
a7601e9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the first pair of sibling nodes, their roles, and the names of differing fields when the one-branch assertion fails. This preserves the original assertion and keeps message contents out of CI logs.
Local unit suite on this commit reported 299 passed, 19 skipped. Full-stack CI before review fixes
Layer 12 of 13. Builds on #3218. Stack index
Note
Report differing fields in
assert_one_branchwhen an integration trace forksImproves the fork assertion in grid.py. When a trace has multiple branches, it now records the first node per parent and, on finding a sibling with the same parent, compares their message fields and tools. The failure message includes the parent, node indexes, roles, and the differing fields. Traces with one branch or no sibling pair still fail with the branch count.
Macroscope summarized a7601e9.
Note
Low Risk
Test-only assertion messaging change; production behavior and pass/fail criteria are unchanged except for richer failure output.
Overview
When integration rollouts unexpectedly fork,
assert_one_branchnow fails with actionable context instead of only reporting the branch count.After the existing early exits for allowed harness forks and single-branch traces, it walks the trace tree to find the first sibling pair (two nodes with the same parent), compares their message model fields and
tools, and reports the parent id, node indexes, roles, and names of differing fields—without dumping message contents into CI logs. If no sibling pair is found, it still fails with the branch count alone.Reviewed by Cursor Bugbot for commit a7601e9. Bugbot is set up for automated code reviews on this repo. Configure here.