fix(orders): fall back to tokenId when tokenIds is empty#1959
Closed
umeeSthein wants to merge 1 commit intoProjectOpenSea:mainfrom
Closed
fix(orders): fall back to tokenId when tokenIds is empty#1959umeeSthein wants to merge 1 commit intoProjectOpenSea:mainfrom
umeeSthein wants to merge 1 commit intoProjectOpenSea:mainfrom
Conversation
59967b4 to
55c41c3
Compare
Collaborator
|
Thanks for this contribution! We've recreated this fix in our internal monorepo and it will be included in the next release sync. Closing this PR as the change will ship from the internal repo — appreciate you flagging it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenIdwhentokenIdsis an empty array inserializeOrdersQueryOptionstokenIds: []+tokenIdcaseWhy
When both
tokenIds: []andtokenIdare provided, the serializer currently prefers the emptytokenIdsarray and drops the token filter entirely from the request.That creates a mismatch with the surrounding validation logic and can send an unfiltered orders request even though a specific
tokenIdwas provided.Testing
tokenIdsfallback case