Fix missing variable definitions and placeholders in advanced use cases docs#1963
Closed
hst0mp0x wants to merge 1 commit intoProjectOpenSea:mainfrom
Closed
Fix missing variable definitions and placeholders in advanced use cases docs#1963hst0mp0x wants to merge 1 commit intoProjectOpenSea:mainfrom
hst0mp0x wants to merge 1 commit intoProjectOpenSea:mainfrom
Conversation
…es docs Given the minor scope of these changes, I did not open a separate ISSUE before submitting this PR. Fixed multiple documentation issues in `advanced-use-cases.md` where variables were used without being defined. **Private Orders:** Replaced undefined `OWNERS_WALLET_ADDRESS` with a consistent `accountAddress` placeholder and added its declaration. **Purchasing for Other Users:** Added missing placeholder declarations for `orderHash`, `protocolAddress`, `accountAddress`, and `recipientAddress`, aligning with patterns used in other examples (including `Seaport 1.6` address). These changes ensure the examples are self-contained, consistent, and can be used without additional guesswork.
Collaborator
|
Thanks for this contribution! We've recreated this fix in our internal monorepo and it will be included in the next release sync. Closing this PR as the change will ship from the internal repo — appreciate you flagging it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Given the minor scope of these changes, I did not open a separate ISSUE before submitting this PR.
Fixed multiple documentation issues in
advanced-use-cases.mdwhere variables were used without being defined.Private Orders: Replaced undefined
OWNERS_WALLET_ADDRESSwith a consistentaccountAddressplaceholder and added its declaration. Purchasing for Other Users: Added missing placeholder declarations fororderHash,protocolAddress,accountAddress, andrecipientAddress, aligning with patterns used in other examples (includingSeaport 1.6address).These changes ensure the examples are self-contained, consistent, and can be used without additional guesswork.