Graph: Add helper function to improve cython type inference#2210
Merged
WyattBlue merged 1 commit intoPyAV-Org:mainfrom Mar 23, 2026
Merged
Graph: Add helper function to improve cython type inference#2210WyattBlue merged 1 commit intoPyAV-Org:mainfrom
WyattBlue merged 1 commit intoPyAV-Org:mainfrom
Conversation
lgeiger
commented
Mar 23, 2026
| @cython.cfunc | ||
| def _register_context(self, ctx: FilterContext): | ||
| self._context_by_ptr[cython.cast(cython.long, ctx.ptr)] = ctx | ||
| self._context_by_name[ctx.ptr.name] = ctx |
Contributor
Author
There was a problem hiding this comment.
_context_by_name is not used anywhere at the moment, so I think we can safely remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_context_by_type.get("buffer", [])doesn't work nicely with cython and can't infer the return type. This introduces a small helper function which allows cython to infer the output type correctly and generate simpler code.