Skip to content

perf: take component sets from the listing - #59

Open
tobixen wants to merge 1 commit into
mainfrom
perf/one-propfind-listing
Open

tobixen wants to merge 1 commit into
mainfrom
perf/one-propfind-listing

Conversation

@tobixen

@tobixen tobixen commented Nov 20, 2026

Copy link
Copy Markdown
Member

Commit message:

perf: take component sets from the listing

Calendars piled up on a Synology server, as the caldav library's tests
added calendars but could not delete them.  With half a thousand of
them, listing went really slow: collections() sent one PROPFIND per
calendar, 268 s against 6 s for the listing alone.  The calendars were
deleted some other way, but the number of PROPFINDs was excessive
anyway.  caldav (from https://github.com/python-caldav/caldav/pull/872,
not yet released) keeps the listing's properties on each calendar, and
the component sets are now read from there.

Bedework 5 also lists "ghost collections" that do not exist.  A
compatibility hint for this has been added to the caldav library, and
where it is set, such ghost collections are weeded out.

Prompts:
> [pick from the task list: "calendaring: list collections with one
> PROPFIND, not one per calendar"]

> so let's go for yet another caldav compatibility hint on the ghost
> collections

> (on the commit message) Please do a QA on the edited text.  Didn't
> we already from earlier cache propfind results in the caldav library?

Assisted-By: Claude Opus 5.5
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

Needs python-caldav/caldav#872 for the speed-up and the hint. CI runs against released caldav (3.7), where the behaviour is unchanged and the new tests skip. Tested locally against that PR's branch and against caldav master, and live on Bedework 5 and the Synology server.

Calendars piled up on a Synology server, as the caldav library's tests
added calendars but could not delete them.  With half a thousand of
them, listing went really slow: collections() sent one PROPFIND per
calendar, 268 s against 6 s for the listing alone.  The calendars were
deleted some other way, but the number of PROPFINDs was excessive
anyway.  caldav (from python-caldav/caldav#872,
not yet released) keeps the listing's properties on each calendar, and
the component sets are now read from there.

Bedework 5 also lists "ghost collections" that do not exist.  A
compatibility hint for this has been added to the caldav library, and
where it is set, such ghost collections are weeded out.

Prompts:
> [pick from the task list: "calendaring: list collections with one
> PROPFIND, not one per calendar"]

> so let's go for yet another caldav compatibility hint on the ghost
> collections

> (on the commit message) Please do a QA on the edited text.  Didn't
> we already from earlier cache propfind results in the caldav library?

Assisted-By: Claude Opus 5.5
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant