Repository navigation
Conversation
Calendars piled up on a Synology server, as the caldav library's tests added calendars but could not delete them. With half a thousand of them, listing went really slow: collections() sent one PROPFIND per calendar, 268 s against 6 s for the listing alone. The calendars were deleted some other way, but the number of PROPFINDs was excessive anyway. caldav (from python-caldav/caldav#872, not yet released) keeps the listing's properties on each calendar, and the component sets are now read from there. Bedework 5 also lists "ghost collections" that do not exist. A compatibility hint for this has been added to the caldav library, and where it is set, such ghost collections are weeded out. Prompts: > [pick from the task list: "calendaring: list collections with one > PROPFIND, not one per calendar"] > so let's go for yet another caldav compatibility hint on the ghost > collections > (on the commit message) Please do a QA on the edited text. Didn't > we already from earlier cache propfind results in the caldav library? Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Needs python-caldav/caldav#872 for the speed-up and the hint. CI runs against released caldav (3.7), where the behaviour is unchanged and the new tests skip. Tested locally against that PR's branch and against caldav master, and live on Bedework 5 and the Synology server.