Skip to content

Add ical_value property to vDuration - #2059

Merged
stevepiercy merged 3 commits into
PyCalendar:mainfrom
arrudagba:issue-876-vduration-ical-value
Nov 13, 2026
Merged

stevepiercy merged 3 commits into
PyCalendar:mainfrom
arrudagba:issue-876-vduration-ical-value

Conversation

@arrudagba

Copy link
Copy Markdown
Contributor

Linked issue

Description

Added the ical_value property to vDuration. It returns the timedelta of the duration, like vUTCOffset in #2013.

Tests cover positive, negative and zero durations, a duration made from a string, and Component.decoded().

The change log file is 876.feature.1, so it does not conflict with 876.feature from #2013.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

The property returns the timedelta of the duration, like
vUTCOffset.ical_value.

AI: Claude Opus 5.5 wrote the property, tests and change log entry
from the plan in PyCalendar#876.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @arrudagba! A maintainer will review it shortly.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Insufficient data

Not enough activity yet to make a reliable assessment.

View full analysis →

This is an automated analysis by AgentScan

niccokunzmann
niccokunzmann previously approved these changes Nov 12, 2026

@niccokunzmann niccokunzmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically correct! Thanks for the contribution. Waiting for a docs review...

@stevepiercy

Copy link
Copy Markdown
Member

@arrudagba would you please resolve the merge conflicts by renaming your news fragment? Thank you!

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and renamed it, since I caused the conflict from another PR merge.

@stevepiercy
stevepiercy enabled auto-merge (squash) November 13, 2026 23:37
@stevepiercy
stevepiercy merged commit ed63cc0 into PyCalendar:main Nov 13, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants