Skip to content

Fix dateutil timezone detection and add Alpine Linux CI coverage - #2101

Open
SemTiOne wants to merge 11 commits into
PyCalendar:mainfrom
SemTiOne:issue-812-alpine-timezone-tests
Open

SemTiOne wants to merge 11 commits into
PyCalendar:mainfrom
SemTiOne:issue-812-alpine-timezone-tests

Conversation

@SemTiOne

Copy link
Copy Markdown
Contributor

Linked issue

Description

Fixes dateutil timezone detection when it uses its bundled zoneinfo. Makes the timezone tests independent of the installed tzdata version and adds an Alpine Linux CI job.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

AI disclosure: GPT-6 Luna reviewed the patch.

Prompt: Review the patch for potential issues and suggestions.
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @SemTiOne! A maintainer will review it shortly.

@niccokunzmann niccokunzmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I added suggestions. Let me know what you think!

By the way: At the moment it is hard to scale with the incoming PRs. Reviews are welcome - and also flagging AI slop.

Comment thread src/icalendar/timezone/tzid.py Resolved
Comment thread .github/workflows/tests.yml Resolved
Comment thread .github/workflows/tests.yml Resolved
Comment thread .github/workflows/tests.yml Resolved
@niccokunzmann

Copy link
Copy Markdown
Member

Let me know when I should have a look.

@SemTiOne

Copy link
Copy Markdown
Contributor Author

@niccokunzmann Ok I think this looks good now. Could you please have a look? Let me know if there's something wrong.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail on Alpine Linux for v6.1.3

2 participants