Skip to content

Fix Windows newline expectations in tests - #2122

Open
SemTiOne wants to merge 2 commits into
PyCalendar:mainfrom
SemTiOne:fix-1062-newline-tests
Open

SemTiOne wants to merge 2 commits into
PyCalendar:mainfrom
SemTiOne:fix-1062-newline-tests

Conversation

@SemTiOne

Copy link
Copy Markdown
Contributor

Linked issue

Description

Use the platform newline in the RFC 6868 and #1445 tests so they pass on Windows.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

Use os.linesep for newline expectations so the tests pass on Windows. AI disclosure: GPT-6 Luna reviewed the patch. Prompt: Review the patch for potential issues and suggestions.
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @SemTiOne! A maintainer will review it shortly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant