Repository navigation
1789-follow-up-xcal-support - #2132
Merged
Merged
Conversation
- Rename XCalComponentParser to XCalComponentsParser
- Add a glossary term and definition for XSD and friends - Add datatypes to Vale dictionary
- Convert comment to TODO for greater visibility.
Contributor
|
Thanks for the pull request, @stevepiercy! A maintainer will review it shortly. |
5 tasks done
niccokunzmann
requested changes
Nov 19, 2026
niccokunzmann
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for taking care of the consistency.
I had a look and have some suggestions.
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>
stevepiercy
commented
Nov 19, 2026
stevepiercy
left a comment
Member
Author
There was a problem hiding this comment.
Please see my comments. Back to you!
3 of 5 tasks
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>
stevepiercy
commented
Nov 20, 2026
stevepiercy
left a comment
Member
Author
There was a problem hiding this comment.
@niccokunzmann one more pass on this last item that I reworded, then it should be good to merge.
Member
Author
|
The failing docs CI check will turn green after merging the comment. It contains the missing term which causes the docs CI failure. |
stevepiercy
enabled auto-merge (squash)
November 20, 2026 05:54
Member
Author
|
And that was the last thing. I set it to automerge, but it needs an approval from @niccokunzmann . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to PR #1789 to enhance docstrings.