Skip to content

1789-follow-up-xcal-support - #2132

Merged
stevepiercy merged 32 commits into
mainfrom
1789-follow-up-xcal-support
Nov 20, 2026
Merged

stevepiercy merged 32 commits into
mainfrom
1789-follow-up-xcal-support

Conversation

@stevepiercy

Copy link
Copy Markdown
Member

Follow up to PR #1789 to enhance docstrings.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @stevepiercy! A maintainer will review it shortly.

@stevepiercy stevepiercy added this to the 8.0.0 milestone Nov 17, 2026
@stevepiercy stevepiercy added doc exempt Exempt from pull request quality check workflow labels Nov 17, 2026

@niccokunzmann niccokunzmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking care of the consistency.

I had a look and have some suggestions.

Comment thread docs/reference/glossary.rst Resolved
Comment thread docs/reference/glossary.rst Resolved
Comment thread src/icalendar/cal/journal.py Resolved
Comment thread src/icalendar/parser/xcal/component.py Resolved
Comment thread docs/reference/glossary.rst Resolved
Comment thread src/icalendar/parser/xcal/component.py Resolved
Comment thread src/icalendar/parser/xcal/component.py Resolved
Comment thread src/icalendar/parser/xcal/property.py Resolved
Comment thread src/icalendar/prop/xml.py Resolved
Comment thread src/icalendar/prop/xml.py Resolved
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. Back to you!

Comment thread docs/reference/glossary.rst Resolved
Comment thread docs/reference/glossary.rst Resolved
Comment thread docs/reference/glossary.rst Resolved
Comment thread src/icalendar/cal/journal.py Resolved
Comment thread src/icalendar/parser/xcal/component.py Resolved
Comment thread src/icalendar/parser/xcal/component.py Resolved
Comment thread src/icalendar/parser/xcal/property.py Resolved

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff

Comment thread src/icalendar/cal/journal.py Resolved

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niccokunzmann one more pass on this last item that I reworded, then it should be good to merge.

#2132 (comment)

@stevepiercy

Copy link
Copy Markdown
Member Author

The failing docs CI check will turn green after merging the comment. It contains the missing term which causes the docs CI failure.

@stevepiercy
stevepiercy enabled auto-merge (squash) November 20, 2026 05:54
@stevepiercy

Copy link
Copy Markdown
Member Author

And that was the last thing. I set it to automerge, but it needs an approval from @niccokunzmann .

@stevepiercy
stevepiercy disabled auto-merge November 20, 2026 12:58
@stevepiercy
stevepiercy merged commit ee113cf into main Nov 20, 2026
27 checks passed
@stevepiercy
stevepiercy deleted the 1789-follow-up-xcal-support branch November 20, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc exempt Exempt from pull request quality check workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants