Repository navigation
feat(todo): add COMPLETED and completed property accessors (#1797) - #2144
Open
RishabhIIITD wants to merge 2 commits into
Open
RishabhIIITD wants to merge 2 commits into
RishabhIIITD wants to merge 2 commits into
Conversation
RishabhIIITD
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 17, 2026 20:51
Contributor
|
Thanks for the pull request, @RishabhIIITD! A maintainer will review it shortly. |
Contributor
|
Thanks for the contribution. However, there's already an open PR (#2023) for this issue. Would you please review that PR and provide some feedback to the author? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
COMPLETEDandcompletedproperty accessors on theTodo(VTODO) component per :rfc:5545#section-3.8.2.1, resolving #1797.Summary of Changes:
COMPLETED = single_utc_property("COMPLETED", ...)onTodoalong with the lowercasecompletedproperty getter, setter, and deleter.completed: date | datetime | None = Noneparameter and assignment inTodo.new(...).COMPLETEDis specified only forVTODOcalendar components.COMPLETED:20070501andCOMPLETED;VALUE=DATE:20070501are properly converted into UTCdatetime.issue_1797_completed_date.icsandissue_1797_completed_datetime.icstosrc/icalendar/tests/todos/.src/icalendar/tests/test_issue_1797_todo_completed.pycovering getter/setter/deleter, fixture loading, serialization, and absence on other components.news/+1797-todo-completed.feature.Closes #1797