Repository navigation
Conversation
Seyamalam
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 20, 2026 06:01
Contributor
|
Thanks for the pull request, @Seyamalam! A maintainer will review it shortly. |
Contributor
Automation signalsActivity patterns show signs of automation. Evidence
Last 5 PRs: This is an automated analysis by AgentScan |
Seyamalam
force-pushed
the
remove-unused-params-method
branch
from
November 20, 2026 11:48
b2395f2 to
9f03969
Compare
The method is an undocumented alias for Parameters.keys() with no callers in the codebase, tests, or documentation, and its body is not covered by the test suite. AI disclosure: I used SWE-2 via Devin to identify dead code with a coverage report and an unreferenced-name analysis, and to draft this change. I reviewed and validated the output locally. Contributes to PyCalendar#641
Seyamalam
force-pushed
the
remove-unused-params-method
branch
from
November 20, 2026 13:08
9f03969 to
d106e8c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
Parameters.params()is an undocumented alias forParameters.keys()with no callers anywhere in the codebase, tests, or documentation. A coverage run shows its body is never executed, and an unreferenced-name analysis confirms nothing calls it (including viagetattr). This removes the method along with the now-unusedKeysViewimport. No behavior change.Checklist
Additional information
Full test suite run: 22414 passed, 42 skipped, 577 xfailed.