Skip to content

Remove unused Parameters.params() method - #2181

Open
Seyamalam wants to merge 1 commit into
PyCalendar:mainfrom
Seyamalam:remove-unused-params-method
Open

Seyamalam wants to merge 1 commit into
PyCalendar:mainfrom
Seyamalam:remove-unused-params-method

Conversation

@Seyamalam

Copy link
Copy Markdown

Linked issue

Description

Parameters.params() is an undocumented alias for Parameters.keys() with no callers anywhere in the codebase, tests, or documentation. A coverage run shows its body is never executed, and an unreferenced-name analysis confirms nothing calls it (including via getattr). This removes the method along with the now-unused KeysView import. No behavior change.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

Additional information

Full test suite run: 22414 passed, 42 skipped, 577 xfailed.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @Seyamalam! A maintainer will review it shortly.

@github-actions

Copy link
Copy Markdown
Contributor

Automation signals

Activity patterns show signs of automation.

View full analysis →

Report this account →

Evidence
  • Fork spike detected: Burst of 18 fork events in a single 24-hour window
  • Very high PR volume (daily): 31 PRs within a single 24-hour window
  • Issue comment and PR within minutes: Commented on an issue and opened a PR to the same repo within 5 minutes, in 4 repositories (the fastest took 42s)
  • 24/7 activity pattern: Active in 23 of 24 hours, with the longest break being only 1.8 hours

Last 5 PRs:

This is an automated analysis by AgentScan

@github-actions github-actions Bot added PR quality: good agentscan:automated-account AgentScan flagged this item as coming from an automated account, and it needs review labels Nov 20, 2026
@Seyamalam
Seyamalam force-pushed the remove-unused-params-method branch from b2395f2 to 9f03969 Compare November 20, 2026 11:48
The method is an undocumented alias for Parameters.keys() with no
callers in the codebase, tests, or documentation, and its body is not
covered by the test suite.

AI disclosure: I used SWE-2 via Devin to identify dead code with a
coverage report and an unreferenced-name analysis, and to draft this
change. I reviewed and validated the output locally.

Contributes to PyCalendar#641
@Seyamalam
Seyamalam force-pushed the remove-unused-params-method branch from 9f03969 to d106e8c Compare November 20, 2026 13:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account AgentScan flagged this item as coming from an automated account, and it needs review PR quality: good

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant