Repository navigation
Add ical_value property to vRecur - #2187
Open
RiccardoBifulco wants to merge 1 commit into
Open
RiccardoBifulco wants to merge 1 commit into
RiccardoBifulco wants to merge 1 commit into
Conversation
The property returns the rule parts as a plain dict of native Python
values, so Component.decoded("RRULE") no longer returns a vRecur.
Part of PyCalendar#876.
RiccardoBifulco
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 20, 2026 19:41
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
|
Thanks for the pull request, @RiccardoBifulco! A maintainer will review it shortly. |
Contributor
Automation signalsActivity patterns show signs of automation. Evidence
Last 5 PRs: This is an automated analysis by AgentScan |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
vRecur.ical_value, returning the rule parts as a plaindictof native Python values (str,int,date,datetime). The result is a copy.Component.decoded("RRULE")now returns this dict instead of avRecur. This is a behaviour change, so I updated the two tests intest_parsing.pythat expected avRecur. Please tell me if you prefer a different return shape.Added tests in
tests/prop/test_vRecur_ical_value.pyand the news entrynews/876.feature.3. Ruff passes and the full test suite passes. ThevRecur.VALUEdoctest fails onmaintoo.I used AI to help with this change.
Closes #876