Skip to content

Add ical_value property to vRecur - #2187

Open
RiccardoBifulco wants to merge 1 commit into
PyCalendar:mainfrom
RiccardoBifulco:876-vrecur-ical-value
Open

RiccardoBifulco wants to merge 1 commit into
PyCalendar:mainfrom
RiccardoBifulco:876-vrecur-ical-value

Conversation

@RiccardoBifulco

Copy link
Copy Markdown

Adds vRecur.ical_value, returning the rule parts as a plain dict of native Python values (str, int, date, datetime). The result is a copy.

Component.decoded("RRULE") now returns this dict instead of a vRecur. This is a behaviour change, so I updated the two tests in test_parsing.py that expected a vRecur. Please tell me if you prefer a different return shape.

Added tests in tests/prop/test_vRecur_ical_value.py and the news entry news/876.feature.3. Ruff passes and the full test suite passes. The vRecur.VALUE doctest fails on main too.

I used AI to help with this change.

Closes #876

The property returns the rule parts as a plain dict of native Python
values, so Component.decoded("RRULE") no longer returns a vRecur.

Part of PyCalendar#876.
Copilot AI balanced review requested due to automatic review settings November 20, 2026 19:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @RiccardoBifulco! A maintainer will review it shortly.

@github-actions

Copy link
Copy Markdown
Contributor

Automation signals

Activity patterns show signs of automation.

View full analysis →

Report this account →

Evidence
  • Extreme fork automation: 43 repositories forked in rapid succession (within 24 hours)
  • Very high PR volume (weekly): 134 PRs within a single 7-day window
  • Very high PR volume (daily): 134 PRs within a single 24-hour window
  • Rapid PRs to repository: 9 PRs opened to emreocell/Praxi-Bot within 61s intervals

Last 5 PRs:

This is an automated analysis by AgentScan

@github-actions github-actions Bot added PR quality: good agentscan:automated-account AgentScan flagged this item as coming from an automated account, and it needs review labels Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account AgentScan flagged this item as coming from an automated account, and it needs review PR quality: good

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly decode every value type (polymorphy, beginner)

2 participants