migrate entrypoints handling to standard library importlib.metadata#589
migrate entrypoints handling to standard library importlib.metadata#589eli-schwartz wants to merge 1 commit intoPyFilesystem:masterfrom
Conversation
We wrap a couple different versions of the stdlib interface, and fall back to pkg_resources for compatibility with existing use cases on very old versions of python. For python 3.8 and on, we make sure to completely avoid external dependencies, even backports. Bug: PyFilesystem#577
|
@althonos I have resurrected #553 in spirit with what I hope is a universally satisfying and backwards-compatible change. What do you think? Please also see some of my other (recent) PRs which improve the testsuite. It would be great to have some of these merged so that we could have a reliable python 3.12 experience. |
|
Can we please get these fixes merged... |
|
I haven't given up on this PR by the way -- I am not aware of any issues with it though, so I'm just waiting for someone with commit access to review... |
|
I remain committed to seeing this and other PRs go through. As a Linux distro maintainer I consider it my duty as a downstream repackager to do what I can to ensure upstream is healthy as well. I do lack any ability to merge, release, or otherwise do anything to fix issues other than propose PRs, but I am happy to do that for whatever it's worth... |
|
@lurch @althonos @willmcgugan, Today's setuptools release has deleted pkg_resources entirely, and pyfilesystem2 is (as a result) completely and utterly broken as it cannot be imported. What can I do to help you merge my PRs? :) |
|
I was about to get working on a PR for the replacement of pkg_resources. I was pleasantly surprised someone else has already done the work, so let's get this merged and keep this project up-to-date. |
|
Any updates on this. Is there a verson of setuptools I can downgrade to in the interim as its blocking me pretty hard at work :( |
|
Ok. For anyone looking for this, there is a working version here: https://github.com/milahu/pyfilesystem2/tree/pkg-resources-part-1-and-2 You'll need to mangle your requirements.txt. / Pipfile / etc to point to that specifically. Hopefully the maintainer of the official version will merge these fixes in. |
You could also just install it from this PR: |
6 participants
We wrap a couple different versions of the stdlib interface, and fall back to pkg_resources for compatibility with existing use cases on very old versions of python.
For python 3.8 and on, we make sure to completely avoid external dependencies, even backports.
Bug: #577