Fix pos mode#494
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 19792c2. Configure here.
* simplified version with transport always in quan * format
n13
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Note
Medium Risk
Changes how payment URL amounts are carried and parsed (wire amount vs localized/display text) and updates POS QR watch/matching logic to rely on raw
BigIntvalues, which could impact payment flows if parsing/formatting expectations differ across locales.Overview
POS mode now passes and validates raw planck amounts end-to-end.
PosQrScreentakesamountPlanck: BigInt(instead of a formatted string), uses it directly for QR request generation and transfer matching, and shows an explicit error for invalid/zero amounts.Payment-intent amount localization via
AmountInputLogicwas removed.parsePaymentUrlAmount/PaymentUrlAmountResult(and related unit tests) were deleted,PaymentIntentno longer exposes anamountPlanckhelper, and the send flow now parsesinitialAmountdifferently for pay mode (parseWireAmount) vs normal send (parseQuanAmount). In pay mode, fiat flipping and the secondary "≈" display are disabled, and QR-scanned payment intents now populate the amount field with the raw URLamountstring.Reviewed by Cursor Bugbot for commit be858c9. Bugbot is set up for automated code reviews on this repo. Configure here.