Repository navigation
Security hotfix, rmcp 3.9.0 and accept narrow SQLite risk to reopen the lane - #145
Merged
Merged
Conversation
cargo-deny closed the lane on RUSTSEC-2026-0457, 0459, 0461 and 0462. rmcp 3.9.0 clears 0457, 0461 and 0462 for the root's 3.x copy. rmcp 1.8.0 has no 1.x fix for 0462 but does not build the affected HTTP client, and libsqlite3-sys cannot move past 0459 until mesh-llm allows it, so both are ignored with the reasoning in deny.toml. The SQLite risk is accepted, not absent. Claude-Account: russelledeming@gmail.com Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Russell: tapping Ship it on this PR accepts one narrow security risk, described under "The risk this accepts".
Why this is a hotfix (
lane:hotfix): at 4:03 AM CT on Mon 9 Nov 2026 the steward's cargo-deny check closed train #144 on new RustSec advisories, and only a hotfix can leave until main passes. A third advisory landed at 4:18 AM CT while this was being built. PR #142 and everything behind it wait on this.What changes
Two files. Nothing under
desktop/, so this needs no launch check.Cargo.lock:rmcpandrmcp-macros3.4.1 to 3.9.0, and nothing else moved. That clears RUSTSEC-2026-0457, 0461 and 0462 for the root's 3.x copy.deny.toml: two new ignores, each with its reasoning and removal condition.Each fix alone fails cargo-deny on the others, so they have to ship together.
The risk this accepts
RUSTSEC-2026-0459 (bundled SQLite before 3.54.0). A database file paired with a crafted
-walfile of a different page size can make ordinary queries return stale bytes from the process's memory.We can't take the fix yet. It needs
libsqlite3-sys0.39, every tagged mesh-llm through v0.78.1 requiresrusqlite^0.40, and Cargo allows only one copy of SQLite in a build.The exposure is narrow but real, which is why the entry says accepted rather than unaffected:
archive/archive.dbinside the nest at every start, and the nest is the working directory of spawned agents. An agent running in an OS sandbox that can write there could plant the pair. Agents without a sandbox already have the user's full authority, so the bug adds nothing for them.The alternative is moving
archive.dbout of the nest into the app data folder, with a one-time migration of a 2.4 GB file. That closes the agent path, but it is a desktop change with its own launch check, so it isn't in this hotfix.RUSTSEC-2026-0462 on
rmcp1.8.0. Unbounded HTTP response bodies. There is no 1.x fix.buzz-agentis the only user and compiles onlyclientandtransport-child-process, so the HTTP client isn't built. The ignore is by id, so it would also hide a 3.x copy, and the comment says 3.x must stay at 3.9.0 or later.Still open after this
rmcp3.2.0 until the stacked follow-up PR lands. That copy compiles only with themesh-llmfeature, which Dreamforge release builds don't enable. Developer builds withjust mesh=1and CI's mesh-llm jobs still compile it until then, and 0462 is hidden on it in the meantime.buzz-dev-mcpships onrmcp3.9.0. The kit's launch check only looks atdesktop/paths, so that sidecar change gets no launch check.How it was checked
--all-features: root passes; desktop fails only on 0457 and 0461 forrmcp3.2.0, which the follow-up clears.cargo check --lockedforbuzz-dev-mcp,buzz-agentandbuzz-mesh-smoke --examples, which compile the mesh-llm crates against 3.9.0. Clippy with-D warningson the first two.buzz-dev-mcptests: 102 library and 2 stdio lifecycle tests pass.deny.tomlcomments from code,cargo tree, the rmcp source and the advisory text. The commit reviewed differs from this one only in the wording of the 0459 comment, which that review asked for.Factory-Task: security/advisories-rustsec-2026-0459-0462
Built-by: claude-code/claude-opus-5-5
Claude-Account: russelledeming@gmail.com
Undo: revert this PR. Main then fails cargo-deny again and the lane stops until another hotfix. A desktop release already published can't be recalled, and an installed app never goes back a version.
🤖 Generated with Claude Code