Skip to content

Show the right message when a member search matches nobody #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuicksilverSlick merged 1 commit into from
Nov 10, 2026
Merged

Show the right message when a member search matches nobody #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions desktop/src/features/channels/ui/MembersSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ export function MembersSidebar({
? pastedProfileQuery.data?.profiles[pastedPubkey]
: undefined;
const pastedKeyResolved =
pastedPubkey !== null &&
pastedProfileQuery.isSuccess &&
!pastedProfileQuery.isFetching &&
!rosterQuery.isLoading;
Expand Down
20 changes: 20 additions & 0 deletions desktop/tests/e2e/channels.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4787,6 +4787,26 @@ test("members sidebar offers nothing for a malformed key", async ({ page }) => {
await expect(page.getByText("No matching people or agents.")).toBeVisible();
});

test("members sidebar keeps the outsider notice to pasted keys once the roster is cached", async ({
page,
}) => {
await page.goto("/");
await openMembersSidebar(page, "general");

const search = page.getByTestId("channel-management-search-users");
const outsiderNotice = page.getByText(
"That key isn’t a member of this community yet.",
);
await search.fill(PASTED_NPUB);
await expect(outsiderNotice).toBeVisible();

await search.clear();
await search.fill("zzzz-matches-nobody");

await expect(page.getByText("No matching people or agents.")).toBeVisible();
await expect(outsiderNotice).toHaveCount(0);
});

test("members sidebar pages add-member search beyond the first 50 people", async ({
page,
}) => {
Expand Down
Loading